Implement MVP for content repos #281
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schnatterer
force-pushed
the
feature/contentRepos
branch
from
eacf2d6 to
704ed42
Compare
Migrate from AirGappedUtils for reuse in Content. Unfortunately, even though an SCM abstraction is right around the corner, it is not there, yet. So I'll have to continue making SCM-Manager-only implementations, that require refactoring soon 😐️
For future re-use
Start removing unused templating params in ArgoCD.groovy. For better UX in content repo templating, these will all have to go!
Creates image pull secrets and adds to config.activeNamespaces that are used for Prometheus, for example. Also makes ArgoCD.groovy use config.application.activeNamespaces as NS list, instead of using hard-coded list. This allows for only creating the namespaces that are active and also adding dynamic NS via config.content.namespaces.
schnatterer
force-pushed
the
feature/contentRepos
branch
from
704ed42 to
e7d1dae
Compare
| @@ -29,6 +29,16 @@ interface ConfigConstants { | |||
|
|
|||
| // Content | |||
| String CONTENT_EXAMPLES_DESCRIPTION = 'Deploy example content: source repos, GitOps repos, Jenkins Job, Argo CD apps/project' | |||
| String CONTENT_NAMESPACES_DESCRIPTION = 'Additional kubernetes namespaces. These are authorized to Argo CD, supplied with image pull secrets, monitored by prometheus, etc. Namespaces can be templates, e.g. ${config.application.namePrefix}staging}' | |||
There was a problem hiding this comment.
typo
Suggested change
| String CONTENT_NAMESPACES_DESCRIPTION = 'Additional kubernetes namespaces. These are authorized to Argo CD, supplied with image pull secrets, monitored by prometheus, etc. Namespaces can be templates, e.g. ${config.application.namePrefix}staging}' | |
| String CONTENT_NAMESPACES_DESCRIPTION = 'Additional kubernetes namespaces. These are authorized to Argo CD, supplied with image pull secrets, monitored by prometheus, etc. Namespaces can be templates, e.g. ${config.application.namePrefix}staging' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.