Skip to content

Update crab client to v3.250522 in prod IB #9916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sinonkt
Copy link
Contributor

@sinonkt sinonkt commented Jun 6, 2025

FYI @belforte

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2025

A new Pull Request was created by @sinonkt for branch IB/CMSSW_15_1_X/master.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2025

cms-bot internal usage

@sinonkt sinonkt mentioned this pull request Jun 6, 2025
3 tasks
@sinonkt
Copy link
Contributor Author

sinonkt commented Jun 6, 2025

@smuzaffar Hi Shazad, There is changes that worth push out for better usability, Could you kindly push this release out earlier to prod please?

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

@sinonkt , can you please resolve the conflicts ?

@belforte
Copy link
Contributor

belforte commented Jun 6, 2025

@sinonkt sorry, but I fail to see the urgency here. Please be so kind to check with me before bugging Shahzad for extra work.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2025

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3827/46582/summary.html
COMMIT: 0e1cef8
CMSSW: CMSSW_15_1_X_2025-06-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9916/46582/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

FATAL: malformed spec found while quering it. Command: 
source /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/rpm-env.sh ;  rpm -q --specfile /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/tmpspec-crab-prod --info --define "cmsdist_directory /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cmsdist" --define "compilerv 1231" --define "cmscompilerv 12" --define "cmsos el8_amd64" --define "almalinux_ver 8" --define "almalinux 8" --define "centos_ver 8" --define "centos 8" --define "rhel 8" --define "dist .el8" --define "el8 1" --define "package_vectorization x86-64-v2" --define "cmsswdata_version_link 1" --define "archfirst yes" --define "cmsBuild_bootstrap 1"  --define 'buildroot /foo'
Resulted in:

warning: line 30: It's not recommended to have unversioned Obsoletes: Obsoletes: cms+crab-prod+1.0
error: line 398: Unknown tag: <<<<<<< HEAD
error: query of specfile /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/tmpspec-crab-prod failed, can't parse
Traceback (most recent call last):
  File "./pkgtools/cmsBuild", line 5086, in 
    build(opts, args[1:], PKGFactory)
  File "./pkgtools/cmsBuild", line 4260, in build


@belforte
Copy link
Contributor

belforte commented Jun 6, 2025

@sinonkt I will explain to you in private where the conflict comes from. Sorry for not noticing it before. For the first few times it is better if you show me the changes before you make the PR

@sinonkt
Copy link
Contributor Author

sinonkt commented Jun 6, 2025

@smuzaffar @belforte Forgive me, Shazad, Stefano. I'll be better aware next time.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2025

Pull request #9916 was updated.

@belforte
Copy link
Contributor

belforte commented Jun 6, 2025

LGTM now

@smuzaffar
Copy link
Contributor

@sinonkt , can you please resolve the conflicts? I think you might have used an old commit of cmsdist and made your changes on top of that. please get the latest cmsdist and then apply your change.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2025

Pull request #9916 was updated.

@smuzaffar
Copy link
Contributor

please test

@sinonkt
Copy link
Contributor Author

sinonkt commented Jun 6, 2025

@smuzaffar Thank you so much Shazad.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3827/46589/summary.html
COMMIT: 4c8a26e
CMSSW: CMSSW_15_1_X_2025-06-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9916/46589/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 12 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4048495
  • DQMHistoTests: Total failures: 46
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4048429
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar merged commit f709081 into cms-sw:IB/CMSSW_15_1_X/master Jun 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants