bug Fix on the average charge computation. #47309
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47309/43636 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
There was a problem hiding this comment.
can you squash the commits to possibly 1 (and not 25)?
Also the PR is blocked by the code quality failure #47309 (comment).
| from Configuration.Eras.Modifier_pp_on_PbPb_run3_cff import pp_on_PbPb_run3 | ||
| from Configuration.ProcessModifiers.trackingNoLoopers_cff import trackingNoLoopers | ||
|
|
||
| Run3_pp_on_PbPb_approxSiStripClusters_2024 = cms.ModifierChain(Run3_2024.copyAndExclude([trackingNoLoopers]), approxSiStripClusters) |
There was a problem hiding this comment.
To re-run the RECO step, where Track,jet and met are reconstructed using approximated cluster collection.
| from Configuration.ProcessModifiers.approxSiStripClusters_cff import approxSiStripClusters | ||
| from Configuration.Eras.Modifier_pp_on_PbPb_run3_cff import pp_on_PbPb_run3 | ||
|
|
||
| Run3_pp_on_PbPb_approxSiStripClusters_2024 = cms.ModifierChain(Run3_2024)#, approxSiStripClusters, pp_on_AA, pp_on_PbPb_run3) |
There was a problem hiding this comment.
This was used to compare the approximated and default strip cluster collection. Anyway, it is droped in the new PR.
|
@icali FYI |
Yes, I created new PR for that #47367 |
PR description:
Correction for Average charge in Approximated cluster
Int avgCharge = cluster.charge()/cluster.size()which doesn't return to nearest integer value in c++. The affect is shown in average charge difference between RAW and RAW' dataset.Int avgCharge - (cluster.charge()+cluster.size()/2)/cluster.size()Compression of barycenter
16 bit Int, choose the float variable and compress the variable usingstd::round(cluster.barycenter() * bit_range / maxBarycenter)bit_rangeis the range of each bit value, e.g. bit range for 16 bit is2^16 - 1 = 65535.maxBarycenteris the maximum value of barycenter which found that is 770.0.Changing the configuration
RECOstep, the configurationConfiguration.Eras.Era_Run2024_pp_on_PbPb_approxSiStripClusterto reconstruct higher objects like jets and MET.