-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Added VPSetTemplate to configuration #47354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
please test |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47354/43695
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Size: This PR adds an extra 36KB to repository Comparison SummarySummary:
|
813752b
to
ca062ca
Compare
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47354/43701
|
Pull request #47354 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again. |
+1 Size: This PR adds an extra 36KB to repository Comparison SummarySummary:
|
Comparison differences are related to #47071 |
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The VPSetTemplate allows one to specify that a VPSet is needed but has no reasonable default value.
PR validation:
New unit tests pass.
resolves cms-sw/framework-team#1227