Skip to content

Phase2-hgx364H Add two new scenario for HGCal V19n and V19ng without cell declaration at G4 geometry level and removing the gaps #48238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2025

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jun 4, 2025

PR description:

Add two new scenarios for HGCal V19n and V19ng without cell declaration at Geant4 geometry level and by removing the gaps. Add 2 new workflows 34834.0 and 35234.0

PR validation:

Use the two new workflows 34834.0 and 35234.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48238/45043

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2025

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Configuration/Geometry (upgrade, geometry)
  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • Configuration/StandardSequences (operations)
  • Geometry/CMSCommonData (upgrade, geometry)
  • Geometry/HGCalCommonData (upgrade, geometry)

@AdrianoDee, @Dr15Jones, @Moanwar, @antoniovilela, @bsunanda, @civanch, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @miquork, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @makortel, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @sameasy, @slomeo, @vargasa this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Jun 4, 2025

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48238/45044

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2025

+1

Size: This PR adds an extra 84KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8aa0ae/46531/summary.html
COMMIT: 3b4f20b
CMSSW: CMSSW_15_1_X_2025-06-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48238/46531/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4041180
  • DQMHistoTests: Total failures: 25
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4041135
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor Author

bsunanda commented Jun 4, 2025

@cmsbuild Please test

@bsunanda
Copy link
Contributor Author

bsunanda commented Jun 9, 2025

@cmsbuild Please test

@bsunanda
Copy link
Contributor Author

bsunanda commented Jun 9, 2025

@subirsarkar Please approve this

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2025

Pull request #48238 was updated. @Moanwar, @antoniovilela, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio, @srimanob, @subirsarkar can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2025

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8aa0ae/46609/summary.html
COMMIT: 6a562f4
CMSSW: CMSSW_15_1_X_2025-06-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48238/46609/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4048495
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4048475
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor Author

bsunanda commented Jun 9, 2025

@subirsarkar @Moanwar Please approve this

@Moanwar
Copy link
Contributor

Moanwar commented Jun 9, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 30ad2dd into cms-sw:master Jun 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants