Skip to content

std math functions replaced with alpaka versions #48378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alexstrel
Copy link

PR description:

This pull request replaces the standard library functions in the Alpaka interface with their Alpaka-equivalent implementations.
The changes primarily affect the workdivision.h header file, aligning the interface more closely with Alpaka cross-platform design.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 20, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48378/45268

  • There are other open Pull requests which might conflict with changes you have proposed:

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@fwyzard
Copy link
Contributor

fwyzard commented Jun 21, 2025

alpaka::math::min and the other alpaka math functions take an acc as first argument.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48378/45283

Code check has found code style and quality issues which could be resolved by applying following patch(s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants