Skip to content

Muon skims for the 2025 light-ion runs #48386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2025

Conversation

flodamas
Copy link
Contributor

PR description:

Implementation of two muon skims for the upcoming light-ion runs (pO / OO / NeNe) based on PAT muon objects. Some EDM collections are removed from the skimmed event contents to reduce the file sizes.

PR validation:

Unit tests passed successfully.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Will be backported to 15_0_X for data taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 23, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @flodamas for master.

It involves the following packages:

  • Configuration/Skimming (pdmv)
  • Configuration/StandardSequences (operations)

@AdrianoDee, @antoniovilela, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @mandrenguyen, @miquork, @rappoccio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @denizsun, @dgulhan, @fabiocos, @felicepantaleo, @makortel, @missirol, @mmusich, @mtosi, @rovere, @salimcerci, @sameasy, @slomeo, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

please test
Although won't be picked up in any existing workflows.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bcc041/46876/summary.html
COMMIT: 1878717
CMSSW: CMSSW_15_1_X_2025-06-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48386/46876/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 23-Jun-2025 16:49:19 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 165121 lumi: 62 event: 23609118 stream: 0
   [1] Running path 'HighPtMuonIonSkimPath'
   [2] Calling method for module PATMuonRefSelector/'highPtMuonSelectorForMuonIon'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<pat::Muon>
Looking for module label: slimmedMuons
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

@flodamas
Copy link
Contributor Author

flodamas commented Jun 23, 2025

Hi, do I understand correctly that the failing workflow is based on Run 1 data whereas miniAOD did not exist at that time?

Workflow 1000 runs all the skims (see step SKIMD), including the MuonPOG skim which is also based on PAT objects, but the latter does not seem to cause any error (skim output file produced but contains 0 event, see runTheMatrix results) probably because none of these RunMinBias2011A events pass the HLT filters.

Please let me know if this is the case so that we can find a solution to the failing test. Thanks!

@youyingli
Copy link
Contributor

youyingli commented Jun 24, 2025

Maybe you can try to add the following code in here.

for s in autoSkim.keys():

    if 'ZeroBias' in s:
        steps['SKIM'+s.upper()+'RUN3_reHLT_2025'] = merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:%s,PAT,NANO,DQM:@rerecoZeroBias+@miniAODDQM+@nanoAODDQM'%(autoSkim[s])},steps['RECONANORUN3_reHLT_2025']])
    elif 'Cosmics' in s:
        steps['SKIM'+s.upper()+'RUN3_reHLT_2025'] = merge([{'--scenario':'cosmics', '-s':'RAW2DIGI,L1Reco,RECO,SKIM:%s,DQM'%(autoSkim[s]), '--datatier':'RECO,DQMIO', '--eventcontent':'RECO,DQM'},steps['RECONANORUN3_reHLT_2025']])
    else:
        steps['SKIM'+s.upper()+'RUN3_reHLT_2025'] = merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:%s,PAT,NANO,DQM:@standardDQM+@miniAODDQM+@nanoAODDQM'%(autoSkim[s])},steps['RECONANORUN3_reHLT_2025']])

Add the following code in here. This uses HIForward 2024 dataset to test including this SKIM.

workflows[143.921] = ['',['RunUPC2024', 'SKIMIONPHYSICS0RUN3_reHLT_2025', 'HARVESTDPROMPTR3']]

This could solve this issue. To test them offline, please use

runTheMatrix.py -w "standard" -l 143.921 and then update this PR.

@cmsbuild
Copy link
Contributor

@mandrenguyen
Copy link
Contributor

urgent
Needed for upcoming "special runs"

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 96KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bcc041/46922/summary.html
COMMIT: 06c85a6
CMSSW: CMSSW_15_1_X_2025-06-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48386/46922/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mandrenguyen
Copy link
Contributor

@cms-sw/upgrade-l2 @cms-sw/pdmv-l2 can you have a look please?

@Moanwar
Copy link
Contributor

Moanwar commented Jun 26, 2025

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4f8d1ea into cms-sw:master Jun 26, 2025
10 checks passed
@mandrenguyen
Copy link
Contributor

This PR seems to cause crashes in workflows 4.17 and 4.29, Run 1 workflows with prompt skims. see for example:
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc12/CMSSW_15_1_X_2025-06-26-2300/pyRelValMatrixLogs/run/4.17_RunMinBias2011A/step5_RunMinBias2011A.log#/

@mmusich
Copy link
Contributor

mmusich commented Jun 27, 2025

This PR seems to cause crashes in workflows 4.17 and 4.29, Run 1 workflows with prompt skims

I guess the same concept to should be applied also for these workflows:

steps['SKIMDreHLT'] = merge([ {'--conditions':'auto:run1_data_%s'%menu, '--hltProcess':'reHLT', '--filein':'file:step3.root'}, steps['SKIMD'] ])

steps['SKIMD'] => steps['SKIMDRun1']

@flodamas
Copy link
Contributor Author

This PR seems to cause crashes in workflows 4.17 and 4.29, Run 1 workflows with prompt skims

I guess the same concept to should be applied also for these workflows:

steps['SKIMDreHLT'] = merge([ {'--conditions':'auto:run1_data_%s'%menu, '--hltProcess':'reHLT', '--filein':'file:step3.root'}, steps['SKIMD'] ])

steps['SKIMD'] => steps['SKIMDRun1']

Oops, sorry for that. I guess I have to make a new PR to fix the master branch.
But the backport to 15_0_X #48397 has not been merged yet and is the most urgent now, should I simply push a new commit there even if the two PRs will differ?

@mmusich
Copy link
Contributor

mmusich commented Jun 27, 2025

should I simply push a new commit there even if the two PRs will differ?

yes, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants