-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Muon skims for the 2025 light-ion runs #48386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48386/45281 |
A new Pull Request was created by @flodamas for master. It involves the following packages:
@AdrianoDee, @antoniovilela, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @mandrenguyen, @miquork, @rappoccio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: RelVals RelVals
|
Hi, do I understand correctly that the failing workflow is based on Run 1 data whereas miniAOD did not exist at that time? Workflow 1000 runs all the skims (see step SKIMD), including the MuonPOG skim which is also based on PAT objects, but the latter does not seem to cause any error (skim output file produced but contains 0 event, see runTheMatrix results) probably because none of these Please let me know if this is the case so that we can find a solution to the failing test. Thanks! |
Maybe you can try to add the following code in here.
Add the following code in here. This uses HIForward 2024 dataset to test including this SKIM.
This could solve this issue. To test them offline, please use
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48386/45296 |
urgent |
+1 Size: This PR adds an extra 96KB to repository Comparison SummarySummary:
|
@cms-sw/upgrade-l2 @cms-sw/pdmv-l2 can you have a look please? |
+Upgrade |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR seems to cause crashes in workflows 4.17 and 4.29, Run 1 workflows with prompt skims. see for example: |
I guess the same concept to should be applied also for these workflows:
|
Oops, sorry for that. I guess I have to make a new PR to fix the master branch. |
yes, please. |
PR description:
Implementation of two muon skims for the upcoming light-ion runs (pO / OO / NeNe) based on PAT muon objects. Some EDM collections are removed from the skimmed event contents to reduce the file sizes.
PR validation:
Unit tests passed successfully.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Will be backported to 15_0_X for data taking.