Skip to content

BPHNano - Backport of https://github.com/cms-sw/cmssw/pull/48385 to CMSSW_15_0_X #48390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025

Conversation

gmelachr
Copy link
Contributor

@gmelachr gmelachr commented Jun 23, 2025

This PR is the backport of #48385 to CMSSW_15_0_X

FYI: @gkaratha @drkovalskyi @vmariani

gmelachr and others added 2 commits June 24, 2025 00:30
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 23, 2025

A new Pull Request was created by @gmelachr for CMSSW_15_0_X.

It involves the following packages:

  • PhysicsTools/BPHNano (xpog)
  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 23, 2025

cms-bot internal usage

@ftorrresd
Copy link
Contributor

enable nano

@ftorrresd
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-979cc7/46885/summary.html
COMMIT: d5ea2ab
CMSSW: CMSSW_15_0_X_2025-06-24-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48390/46885/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 790 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 88860
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 88860
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 21 files compared)
  • Checked 134 log files, 80 edm output root files, 22 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001_NANOmc106Xul16v2 3.118 3.118 0.000 ( +0.0% ) 3.78 3.83 -1.1% 2.727 2.559
2500.002_NANOmc106Xul17v2 3.177 3.177 0.000 ( +0.0% ) 3.56 3.58 -0.5% 3.206 3.048
2500.003_NANOmc106Xul18v2 3.128 3.128 0.000 ( +0.0% ) 3.60 3.65 -1.2% 3.215 3.033
2500.011_NANOdata106Xul16v2 1.560 1.560 0.000 ( +0.0% ) 6.30 6.39 -1.3% 2.847 2.660
2500.012_NANOdata106Xul17v2 1.948 1.948 0.000 ( +0.0% ) 4.23 4.25 -0.7% 3.030 2.852
2500.013_NANOdata106Xul18v2 1.914 1.914 0.000 ( +0.0% ) 5.03 5.10 -1.4% 2.955 2.761
2500.021_NANOmcUL16APVreMINI 0.022 0.022 0.000 ( +0.0% ) 1.83 1.84 -0.0% 2.954 2.757
2500.022_NANOmcUL16reMINI 0.022 0.022 0.000 ( +0.0% ) 1.77 1.78 -0.4% 2.943 2.754
2500.023_NANOmcUL17reMINI 0.022 0.022 0.000 ( +0.0% ) 1.60 1.55 +3.7% 2.664 2.482
2500.024_NANOmcUL18reMINI 0.022 0.022 0.000 ( +0.0% ) 1.39 1.42 -1.6% 3.055 2.870
2500.031_NANOdataUL16APVreMINI 0.035 0.035 0.000 ( +0.0% ) 1.59 1.58 +0.6% 2.891 2.699
2500.032_NANOdataUL16reMINI 0.036 0.036 0.000 ( +0.0% ) 1.60 1.59 +0.5% 2.885 2.707
2500.033_NANOdataUL17reMINI 0.037 0.037 0.000 ( +0.0% ) 1.53 1.54 -0.9% 2.927 2.744
2500.034_NANOdataUL18reMINI 0.036 0.036 0.000 ( +0.0% ) 1.54 1.55 -0.6% 2.923 2.728
2500.101_NANOmc130X 3.220 3.220 0.000 ( +0.0% ) 4.35 4.39 -1.1% 3.130 2.962
2500.111_NANOdata130Xrun3 1.799 1.799 0.000 ( +0.0% ) 6.41 6.50 -1.4% 2.818 2.650
2500.131_ScoutingNANOdata130Xrun3 0.771 0.771 0.000 ( +0.0% ) 33.25 34.09 -2.5% 1.676 1.620
2500.221_muPOGNANOmc140X 2.065 2.065 0.000 ( +0.0% ) 5.59 5.75 -2.9% 2.243 2.245
2500.222_EGMNANOmc140X 3.876 3.876 0.000 ( +0.0% ) 4.01 4.09 -2.1% 2.606 2.584
2500.223_BTVNANOmc140X 10.607 10.607 0.000 ( +0.0% ) 2.57 2.59 -0.9% 2.815 2.798
2500.224_jmeNANOmc140X 6.666 6.666 0.000 ( +0.0% ) 1.14 1.16 -1.0% 2.678 2.640
2500.226_lepTrackInfoNANOmc140X 3.570 3.570 0.000 ( +0.0% ) 3.99 4.08 -2.1% 2.606 2.580
2500.227_ScoutingNANOmc140X 1.486 1.486 0.000 ( +0.0% ) 15.47 15.62 -0.9% 1.925 1.874
2500.228_ScoutingNANOwithPromptmc140X 4.474 4.474 0.000 ( +0.0% ) 3.39 3.41 -0.6% 2.898 2.806
2500.231_muPOGNANO140Xrun3 1.469 1.469 0.000 ( +0.0% ) 7.81 8.01 -2.5% 2.570 2.568
2500.232_EGMNANOdata140Xrun3 2.623 2.623 0.000 ( +0.0% ) 5.86 5.92 -1.1% 2.925 2.930
2500.233_BTVNANOdata140Xrun3 5.612 5.612 0.000 ( +0.0% ) 3.75 3.79 -0.9% 3.144 3.124
2500.234_jmeNANOdata140Xrun3 3.976 3.976 0.000 ( +0.0% ) 1.48 1.51 -2.1% 2.966 2.967
2500.236_lepTrackInfoNANOdata140Xrun3 2.413 2.413 0.000 ( +0.0% ) 5.79 5.93 -2.5% 2.919 2.915
2500.237_ScoutingNANOdata140Xrun3 1.101 1.101 0.000 ( +0.0% ) 29.40 29.74 -1.1% 1.657 1.644
2500.238_ScoutingNANOwithPromptdata140Xrun3 2.783 2.783 0.000 ( +0.0% ) 5.15 5.22 -1.4% 3.091 3.146
2500.241_l1DPGNANO140Xrun3 9.404 9.404 0.000 ( +0.0% ) 6.79 6.10 +11.4% 1.927 1.924
2500.242_muDPGNANO140Xrun3 10.331 10.331 0.000 ( +0.0% ) 1.63 1.64 -0.9% 1.723 1.724
2500.243_muDPGNANOBkg140Xrun3 2.712 2.712 0.000 ( +0.0% ) 15.52 15.01 +3.4% 1.061 1.058
2500.244_hcalDPGNANO140Xrun3 486.016 486.016 0.000 ( +0.0% ) 1.14 1.15 -0.7% 1.684 1.708
2500.245_hcalDPGCalibNANO140Xrun3 826.413 826.413 0.000 ( +0.0% ) 1.52 1.54 -1.2% 1.670 1.681
2500.251_hcalDPGMCNANO140Xrun3 645.333 645.333 0.000 ( +0.0% ) 1.65 1.67 -1.3% 1.779 1.777
2500.261_NANOmc2024reMINI 0.021 0.021 0.000 ( +0.0% ) 1.61 1.64 -1.5% 3.107 3.098
2500.271_NANOdata2024reMINI 0.036 0.036 0.000 ( +0.0% ) 1.65 1.68 -2.2% 2.899 2.898
2500.301_NANOmc150X 3.218 3.218 0.000 ( +0.0% ) 18.18 18.43 -1.4% 2.710 2.697
2500.311_NANOdata150X 2.144 2.144 0.000 ( +0.0% ) 35.60 36.23 -1.7% 2.440 2.444
2500.312_NANOdata150X 2.630 2.630 0.000 ( +0.0% ) 27.62 27.35 +1.0% 2.537 2.532
2500.321_muPOGNANOmc150X 2.255 2.255 0.000 ( +0.0% ) 16.82 16.86 -0.2% 2.593 2.597
2500.322_EGMNANOmc150X 4.110 4.110 0.000 ( +0.0% ) 15.10 15.06 +0.3% 2.691 2.698
2500.323_BTVNANOmc150X 10.551 10.551 0.000 ( +0.0% ) 4.99 5.05 -1.2% 2.912 2.917
2500.324_jmeNANOmc150X 6.760 6.760 0.000 ( +0.0% ) 1.40 1.40 +0.1% 2.250 2.885
2500.325_jmeNANOrePuppimc150X 6.762 6.762 0.000 ( +0.0% ) 1.29 1.29 +0.2% 2.543 3.162
2500.326_lepTrackInfoNANOmc150X 3.720 3.720 0.000 ( +0.0% ) 16.01 16.18 -1.1% 2.688 2.690
2500.327_ScoutingNANOmc150X 1.562 1.562 0.000 ( +0.0% ) 19.55 19.52 +0.2% 2.452 2.458
2500.328_ScoutingNANOwithPromptmc150X 4.773 4.773 0.000 ( +0.0% ) 10.71 10.78 -0.7% 2.926 2.926
2500.329_BPHNANOmc150X 4.108 4.127 -0.019 ( -0.5% ) 17.44 17.60 -0.9% 2.749 2.763
2500.331_muPOGNANO150Xrun3 1.125 1.125 0.000 ( +0.0% ) 29.73 30.90 -3.8% 2.359 2.362
2500.332_EGMNANOdata150Xrun3 2.985 2.985 0.000 ( +0.0% ) 26.80 26.65 +0.6% 2.440 2.439
2500.333_BTVNANOdata150Xrun3 7.971 7.971 0.000 ( +0.0% ) 6.15 6.06 +1.4% 2.660 2.655
2500.334_jmeNANOdata150Xrun3 4.349 4.349 0.000 ( +0.0% ) 1.70 1.71 -0.3% 2.313 2.598
2500.335_jmeNANOrePuppidata150Xrun3 4.332 4.332 0.000 ( +0.0% ) 1.48 1.48 -0.4% 2.582 2.874
2500.336_lepTrackInfoNANOdata150Xrun3 2.625 2.625 0.000 ( +0.0% ) 28.44 27.74 +2.5% 2.431 2.437
2500.337_ScoutingNANOdata150Xrun3 1.737 1.737 0.000 ( +0.0% ) 31.86 31.57 +0.9% 1.629 1.671
2500.338_ScoutingNANOwithPromptdata150Xrun3 2.601 2.601 0.000 ( +0.0% ) 18.04 18.11 -0.4% 2.710 2.707
2500.339_BPHNANOdata150Xrun3 2.604 2.632 -0.028 ( -1.1% ) 35.42 34.65 +2.2% 2.484 2.498
2500.901_TTbarMINIAOD10.6_UL18v2 1.819 1.819 0.000 ( +0.0% ) 32.92 32.87 +0.1% 1.874 1.880
2500.902_TTbarMINIAOD14.0 1.665 1.665 0.000 ( +0.0% ) 32.36 30.37 +6.6% 1.462 1.462
2500.911_DYToLL_M-50_13TeV_pythia8 14.345 14.345 0.000 ( +0.0% ) 8.45 7.82 +8.1% 1.093 1.095
2500.912_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV 0.438 0.199 0.239 ( +119.9% ) 2.79 2.29 +21.9% 0.849 0.842
2500.913_TTbar_Pow_LHE_13TeV 0.110 0.110 0.000 ( +0.0% ) 2.62 2.70 -3.1% 0.850 0.843

@mmusich
Copy link
Contributor

mmusich commented Jun 25, 2025

backport of #48385

@ftorrresd
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 695612c into cms-sw:CMSSW_15_0_X Jul 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants