Skip to content

[L1T] Implementing sector based mode 7 promotion in EMTF for Run 3 2025 #48423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

eyigitba
Copy link
Contributor

PR description:

This PR implements the new sector based quality promotion of mode 7 tracks. The firmware was deployed On June 6th, the first run with this firmware is 393039. The JIRA is here: https://its.cern.ch/jira/browse/CMSLITOPS-511

This change in the emulator is required to keep the emulator in line with the firmware. This is not critical for data taking, but it's used in DQM data-emulator comparisons and also in MC production.

PR validation:

Validated with running on data from before/after run 393039 and also with MC. Works as expected.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This will be backported to 15_0_X for data taking and MC production purposes

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 26, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @eyigitba for master.

It involves the following packages:

  • L1Trigger/L1TMuonEndCap (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @missirol, @mmusich, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@BenjaminRS
Copy link
Contributor

Please test

@eyigitba eyigitba changed the title [15_1_X] Implementing sector based mode 7 promotion in EMTF for Run 3 2025 [L1T] Implementing sector based mode 7 promotion in EMTF for Run 3 2025 Jun 26, 2025
@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0b584/46931/summary.html
COMMIT: 8a238ae
CMSSW: CMSSW_15_1_X_2025-06-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48423/46931/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4065619
  • DQMHistoTests: Total failures: 21
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4065578
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@BenjaminRS
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1a09f40 into cms-sw:master Jun 26, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants