Skip to content

[15.0.X] ScoutingCollectionMonitor add muon "Vtx" collections #48456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 1, 2025

backport of #48453

PR description:

This PR is a follow-up to #47923 and #48089.
In the first implementation of ScoutingCollectionMonitor we didn't add the monitoring of the muons coming from the "Vtx" reconstruction (collection hltScoutingMuonPackerVtx). We're adding support for that in this PR.
In the meanwhile, I correct what I think it's a bug.
The displacedVertices used to have the followingInputTag ("hltScoutingMuonPackerNoVtx","displacedVtx") (so the vertex coming from the "noVtx" reconstruction). IIUC that's the just the PV of the event. I substitute that with ("hltScoutingMuonPackerVtx","displacedVtx") which should contain the vertex from the di-muon.

PR validation:

I've run the following workflows:

runTheMatrix.py -l 145.415 -t 4 -j 8  # 47327

as well as

voms-proxy-init -voms cms
setenv X509_USER_PROXY /tmp/x509_....
runTheMatrix.py --what data_highstats -l 2025.016005 -t 4 -j 8 -i all --ibeos --nEvents 100  # 48281

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #48453 for 2025 data-taking operations.

Cc: @jprendi

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Jul 1, 2025
@mmusich
Copy link
Contributor Author

mmusich commented Jul 1, 2025

type ngt

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2025

A new Pull Request was created by @mmusich for CMSSW_15_0_X.

It involves the following packages:

  • DQM/HLTEvF (hlt, dqm)

@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @ctarricone, @mmusich, @rseidita can you please review it and eventually sign? Thanks.
@missirol, @mtosi this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2025

cms-bot internal usage

mmusich and others added 2 commits July 1, 2025 18:18
- fix the displacedVertices input collections
@mmusich mmusich force-pushed the scoutingMonitor_addMuonVtx_15_0_X branch from 443ebba to 801c9de Compare July 1, 2025 16:23
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2025

Pull request #48456 was updated. @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @ctarricone, @mmusich, @rseidita can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jul 1, 2025

test parameters:

  • workflow = 145.415

@mmusich
Copy link
Contributor Author

mmusich commented Jul 1, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2025

Pull request #48456 was updated. @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @ctarricone, @mmusich, @rseidita can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jul 1, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2025

-1

Failed Tests: UnitTests
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-728921/47035/summary.html
COMMIT: 3021ac7
CMSSW: CMSSW_15_0_X_2025-07-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48456/47035/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 46 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 4104591
  • DQMHistoTests: Total failures: 8688
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4095883
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 25.45 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 145.415 ): 25.450 KiB HLT/ScoutingOffline
  • Checked 221 log files, 193 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Jul 2, 2025

let's wait to have an IB in 15.0.X which solves #48443 to test again, in order to get cleaner comparisons.

@mmusich
Copy link
Contributor Author

mmusich commented Jul 2, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2025

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-728921/47043/summary.html
COMMIT: 3021ac7
CMSSW: CMSSW_15_0_X_2025-07-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48456/47043/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 4104591
  • DQMHistoTests: Total failures: 61
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4104510
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 25.45 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 145.415 ): 25.450 KiB HLT/ScoutingOffline
  • Checked 221 log files, 193 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Jul 3, 2025

+hlt

@antoniovagnerini
Copy link

+dqm

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit df0b9b8 into cms-sw:CMSSW_15_0_X Jul 7, 2025
9 checks passed
@mmusich mmusich deleted the scoutingMonitor_addMuonVtx_15_0_X branch July 7, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants