Skip to content

remove warnings about UnusedProductsForCanDeleteEarly in the phase-2 HLT menu #48470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 3, 2025

PR description:

Title says it all, addresses #48294, by following #48294 (comment)

PR validation:

Run successfully runTheMatrix.py -l ph2_hlt -i all --ibeos and observed that the warnings are removed.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, not to be backported.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jul 3, 2025

test parameters:

  • workflow = ph2_hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jul 3, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff357e/47062/summary.html
COMMIT: c89339c
CMSSW: CMSSW_15_1_X_2025-07-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48470/47062/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Jul 3, 2025

You potentially removed 314 lines from the logs

extra logging is removed

DQMHistoTests: Total failures: 5

no unexpected failures in the monitoring.

@mmusich
Copy link
Contributor Author

mmusich commented Jul 3, 2025

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c9d99e2 into cms-sw:master Jul 4, 2025
11 checks passed
@mmusich mmusich deleted the mm_dev_removeWarning_from_Ph2_HLTmenu branch July 4, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants