-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Improved Event Content for the TkAlHLT*
ALCARECO
#48474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Event Content for the TkAlHLT*
ALCARECO
#48474
Conversation
…ing closest vertex to resonance
…avours, add collection of pixeltracks associated to hardest vertex in hltPixelVertices
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48474/45400 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@atpathak, @cmsbuild, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
please test |
+4% increase (unless there is a typo in the absolute sizes) |
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
I corrected the description. It would be good to have feedback on this proposal as eventually it would be needed for the restart of pp data-taking (so for the next 15.0.X release) |
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a follow-up to PR #46888 which introduced the High Granularity Tracker Alignment Prompt Calibration Loop for HLT alignment conditions. In that PR two new flavours of ALCARECO were introduced
TkAlHLTTracks
andTkAlHLTTracksZMuMu
.I add in this PR the
hltPixelVertices
collection to the list of HLT products saved in both ALCARECO flavours.Then I profit of the existing machinery from
AlignmentTracksFromVertexSelector
in order to save also all the pixel tracks associated to thehltPixelVertex
closest in space to the di-muon decay vertex selected byTkAlHLTTracksZMuMu
(not necessarily the hardest in the event).In this way it would be possible to recompute offline the vertex with different calibration constants and measure the impact of that.
I profit of this PR to introduce in commit 757f9c7 a small bug-fix in order to consume an intermediated collection only when it's needed.
PR validation:
Run successfully the following command :
on 10k input events:
ALCA:TkAlHLTTracks
. The size of the output fileTkAlHLTTracks.root
goes form348M
to362M
(i.e. a +4.02% increase)ALCA:TkAlHLTTracksZMuMu
. The size of the output fileTkAlHLTTracksZMuMu.root
goes from4.2M
to7.9M
(i.e. a +88% increase -- though the event size per event remains fairly small 11kB/event).If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but it will be backported to CMSSW_15_0_X for data-taking operations.