Skip to content

Improved Event Content for the TkAlHLT* ALCARECO #48474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 3, 2025

PR description:

This PR is a follow-up to PR #46888 which introduced the High Granularity Tracker Alignment Prompt Calibration Loop for HLT alignment conditions. In that PR two new flavours of ALCARECO were introduced TkAlHLTTracks and TkAlHLTTracksZMuMu.
I add in this PR the hltPixelVertices collection to the list of HLT products saved in both ALCARECO flavours.
Then I profit of the existing machinery from AlignmentTracksFromVertexSelector in order to save also all the pixel tracks associated to the hltPixelVertex closest in space to the di-muon decay vertex selected by TkAlHLTTracksZMuMu (not necessarily the hardest in the event).
In this way it would be possible to recompute offline the vertex with different calibration constants and measure the impact of that.
I profit of this PR to introduce in commit 757f9c7 a small bug-fix in order to consume an intermediated collection only when it's needed.

PR validation:

Run successfully the following command :

#!/bin/bash -ex

cmsDriver.py testReAlCaHLT \
	     -s ALCA:TkAlHLTTracks+TkAlHLTTracksZMuMu  \
	     --conditions 150X_dataRun3_HLT_v1 \
	     --scenario pp \
	     --data \
	     --era Run3_2025 \
	     --datatier ALCARECO \
	     --eventcontent ALCARECO \
	     --processName=ReAlCa \
	     -n 10000 \
	     --dasquery='file dataset=/HLTMonitor/Run2025C-Express-v2/FEVTHLTALL site=T2_CH_CERN' \
	     --nThreads 4 >& ReAlCa.log

on 10k input events:

  • 9900 events are selected by ALCA:TkAlHLTTracks. The size of the output file TkAlHLTTracks.root goes form 348M to 362M (i.e. a +4.02% increase)
  • 706 events are selected by ALCA:TkAlHLTTracksZMuMu. The size of the output file TkAlHLTTracksZMuMu.root goes from 4.2M to 7.9M (i.e. a +88% increase -- though the event size per event remains fairly small 11kB/event).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but it will be backported to CMSSW_15_0_X for data-taking operations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Alignment/CommonAlignmentProducer (alca)

@atpathak, @cmsbuild, @perrotta can you please review it and eventually sign? Thanks.
@adewit, @missirol, @mmusich, @pakhotin, @rsreds, @tlampen, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jul 3, 2025

test parameters:

  • workflow = 1002.5

@mmusich
Copy link
Contributor Author

mmusich commented Jul 3, 2025

please test

@perrotta
Copy link
Contributor

perrotta commented Jul 3, 2025

  • 9900 events are selected by ALCA:TkAlHLTTracks. The size of the output file TkAlHLTTracks.root goes form 348M to 362M (i.e. a +1.17% increase)

+4% increase (unless there is a typo in the absolute sizes)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-83914e/47067/summary.html
COMMIT: fc071fb
CMSSW: CMSSW_15_1_X_2025-07-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48474/47067/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Jul 4, 2025

+4% increase (unless there is a typo in the absolute sizes)

I corrected the description. It would be good to have feedback on this proposal as eventually it would be needed for the restart of pp data-taking (so for the next 15.0.X release)

@perrotta
Copy link
Contributor

perrotta commented Jul 5, 2025

+alca

  • after confrontation with AlCa-TSG contacts it looks like the reported increase in event size can be affordable

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7728310 into cms-sw:master Jul 5, 2025
11 checks passed
@mmusich mmusich deleted the mm_improve_evtContent_ALCARECOTkAlHLTTracks_v2 branch July 5, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants