Remove last dependency on deislabs/cnab-go#168
Merged
silvin-lubecki merged 2 commits intocnabio:masterfrom Dec 27, 2019
Merged
Conversation
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
- Refreshing some dependencies - Also removing all unused dependencies - Had to re-add manually github.com/Azure/go-autorest dependency in go.mod Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
radu-matei
approved these changes
Dec 26, 2019
Member
radu-matei
left a comment
radu-matei
left a comment
There was a problem hiding this comment.
Thanks a lot for thoroughly going through the remaining places where deislabs was used!
LGTM
vdice
approved these changes
Dec 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A last piece of dependency remained in the go.mod file, making downstream projects still depend on
github.com/deislabs/cnab-go.I also used this PR to run
go mod tidyand clean all unused dependencies. Only one was not removed successfullygithub.tiyicn.workers.dev/Azure/go-autorest, so I had to re-add it manually.