✨ feature: monitoring of benchmark pipeline#186
✨ feature: monitoring of benchmark pipeline#186dipankardas011 wants to merge 7 commits intocncf-tags:mainfrom
Conversation
Co-authored-by: AntonioDiTuri <anto.dituri@gmail.com> Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
rossf7
left a comment
There was a problem hiding this comment.
@dipankardas011 This is looking good 🙌
Thank you for opening the new PR and sorry my feedback is late here
|
One thing to mention the prometheusURL also needs to be set in the benchmark workflow but I don't think we can use the service URL because the pipeline is running outside the bare metal cluster. I think we should be able to use port forwarding for this. I can do some investigation on that. |
Refer: cncf-tags#186 (comment) Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
- Updated Prometheus queries in benchmarking to include the `green-software.foundation/project` label for more granular metrics collection. - Passed `cncfProject` parameter through benchmarking pipeline. - Added the project label to Falco deployment YAMLs for correct metrics attribution. - Bumped Dagger version to 0.18.17 in workflows and config. Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
|
Updates If you guys can check and let me know |
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
|
@AntonioDiTuri and I tried to run the dagger setup but it failed becuase of some get http call not sure what has changed even ran it on dagger latest version and we got the same error $ make setup
dagger call setup-cluster \
--source=. --kubeconfig=/src/green-reviews-test-kubeconfig
▶ connect 0.3s
▼ load module: . 0.5s ERROR
! failed to get configured module: failed to resolve dep to source: failed to load git dep: select: failed to resolve git src: failed to resolve git src: select: load: Get
"https://github.com/marcosnils/daggerverse/info/refs?service=git-upload-pack": EOF
╰─▼ finding module configuration 0.5s ERROR
! failed to resolve dep to source: failed to load git dep: select: failed to resolve git src: failed to resolve git src: select: load: Get
"https://github.com/marcosnils/daggerverse/info/refs?service=git-upload-pack": EOF
╰─▼ moduleSource(refString: "."): ModuleSource! 0.3s ERROR
! failed to resolve dep to source: failed to load git dep: select: failed to resolve git src: failed to resolve git src: select: load: Get
"https://github.com/marcosnils/daggerverse/info/refs?service=git-upload-pack": EOF
╰─▼ moduleSource(refString: "github.com/marcosnils/daggerverse/k3s@k3s/v0.1.10", refPin: "28eea1fcf3b6ecb38a628186107760acd717442f"): ModuleSource! 0.3s ERROR
! failed to resolve git src: failed to resolve git src: select: load: Get "https://github.com/marcosnils/daggerverse/info/refs?service=git-upload-pack": EOF
╰─▼ git(url: "github.com/marcosnils/daggerverse"): GitRepository! 0.3s ERROR
! load: Get "https://github.com/marcosnils/daggerverse/info/refs?service=git-upload-pack": EOF
╰─✘ git(url: "https://github.com/marcosnils/daggerverse"): GitRepository! 0.3s ERROR
! Get "https://github.com/marcosnils/daggerverse/info/refs?service=git-upload-pack": EOF
Setup tracing at https://dagger.cloud/traces/setup. To hide set DAGGER_NO_NAG=1
A new release of dagger is available: v0.18.17 → v0.19.9
To upgrade, see https://docs.dagger.io/install
https://github.com/dagger/dagger/releases/tag/v0.19.9
make: *** [Makefile:43: setup] Error 1cc @rossf7 |
- Bump Go version to 1.24.0 in go.mod - Upgrade go.opentelemetry.io/otel and related packages to v1.39.0 - Update github.com/go-logr/logr to v1.4.3 and testify to v1.11.1 - Add indirect dependency github.com/cespare/xxhash/v2 v2.3.0 - Update Makefile to use dagger helm chart version 0.18.17 Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
What type of PR is this?
kind/feature
What this PR does / why we need it:
This pull request introduces significant updates to the benchmarking pipeline, including dependency upgrades, Prometheus integration for metrics collection, and configuration changes. The most important changes are grouped below by theme.
Dependency and version upgrades:
.github/workflows/benchmark-pipeline-test.ymland.github/workflows/benchmark-pipeline.yamlfrom0.15.4to0.16.1. ([[1]](https://github.com/cncf-tags/green-reviews-tooling/pull/186/files#diff-d9c934bf74594c45f654a9bcdab4f25a8d9dbbb3367de4472cc7c6784aa748e7L14-R14),[[2]](https://github.com/cncf-tags/green-reviews-tooling/pull/186/files#diff-7f28765429fc267e45f03a1a5fd941e11c69d6ec082e7239a26d49c57a7454bfL56-R56))dagger.jsonto use engine versionv0.18.9. ([dagger.jsonL3-R3](https://github.com/cncf-tags/green-reviews-tooling/pull/186/files#diff-e964604c425d3c5c8d0ae8c344aab349365451280b00c3d3e0840e50aec859c9L3-R3))go.mod, includinggqlgen,genqlient,otel, and Prometheus libraries. Added new indirect dependencies likejson-iterator/goandmodern-go/concurrent. ([[1]](https://github.com/cncf-tags/green-reviews-tooling/pull/186/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6L6-R25),[[2]](https://github.com/cncf-tags/green-reviews-tooling/pull/186/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R34-R47))Metrics collection integration:
pkg/pipeline/prom_query.goto enable querying metrics with time ranges. ([pkg/pipeline/prom_query.goR1-R56](https://github.com/cncf-tags/green-reviews-tooling/pull/186/files#diff-abd34464b28f4eccce349ee4295767327b4756eb365755f6e5cd7decb058cfd0R1-R56))computeBenchmarkingResultsinpkg/pipeline/metrics.goto collect and process benchmarking metrics such as CPU usage and memory consumption using Prometheus queries. ([pkg/pipeline/metrics.goR1-R70](https://github.com/cncf-tags/green-reviews-tooling/pull/186/files#diff-bcd4d47a171e6ad6247e36ee29e906142413a93b35ca0486815f992688dc9935R1-R70))pkg/pipeline/benchmark.go. ([pkg/pipeline/benchmark.goR57-R67](https://github.com/cncf-tags/green-reviews-tooling/pull/186/files#diff-e7e55efd9a4a470f3778ca87e80157deca63a9b2c00ce2214747da037d75daeeR57-R67))Configuration improvements:
Makefilefrom60sto120sand added a success message after installation. ([MakefileL26-R34](https://github.com/cncf-tags/green-reviews-tooling/pull/186/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L26-R34))sourcefield fromdagger.json. ([dagger.jsonL13-R13](https://github.com/cncf-tags/green-reviews-tooling/pull/186/files#diff-e964604c425d3c5c8d0ae8c344aab349365451280b00c3d3e0840e50aec859c9L13-R13))Which issue(s) this PR fixes:
Fixes #159
data looked something like this
Special notes for your reviewer (optional):