Skip to content

Cmake fix #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Cmake fix #74

merged 4 commits into from
Feb 2, 2023

Conversation

Jeroenvh99
Copy link
Contributor

I found the thing that if glfw is not installed you needed to uncomment two lines and comment another line in the CMakeLists file a bit annoying, so I fixed that, also I added the instruction that you should go inside the MLX folder to build.

Jeroen Van Halderen and others added 4 commits February 2, 2023 11:25
@W2Wizard W2Wizard added Documentation Improvements or additions to documentation Fix Fixed or resolved an issue labels Feb 2, 2023
Copy link
Collaborator

@W2Wizard W2Wizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I also added some messaging and specified the usage of parallel jobs to speed up the build times.

@W2Wizard W2Wizard merged commit fb233fe into codam-coding-college:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Fix Fixed or resolved an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants