Change testing framework to CMake #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead use BUILD_TESTS variable for it
|
Changed variable used to enable tests from CMAKE_BUILD_TYPE=Test to BUILD_TESTS, to avoid later issues with different build types like release and debug. |
`sprintf` is deprecated due to security concerns
W2Wizard
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to change the unit tests to CMake, let me know what you think of it.
Please note that CMake includes a testing feature named ctest (confusing names...)
Changed the framework from ctest to Google Test, as I worked with it before, and it integrates nicely with ctest(CMake ctest)
to build the test and mlx42:
cmake -DCMAKE_BUILD_TYPE=Test -B build && cmake --build buildrun the tests:
ctest --output-on-failure --test-dir build