Skip to content

chore: update phpstan baseline #9609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

paulbalandan
Copy link
Member

Description
Updates the baseline. Our phpstan rules get a bit smarter by allowing argv and argc offsets, since the Superglobals class only accepts string values and these two are not.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Verified

This commit was signed with the committer’s verified signature.
paulbalandan John Paul E. Balandan, CPA
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@paulbalandan paulbalandan merged commit 764cd55 into codeigniter4:develop Jun 24, 2025
49 checks passed
@paulbalandan paulbalandan deleted the update-baseline branch June 24, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants