-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Closed
Milestone
Description
Update Dock Icon
I want to prefix this with this is super nitpicky. I love code-server, but the current dock icon stands out from other applications in the dock in an unpleasant way. I reworked the current design to match the macOS Big Sur icon style, and I think it looks a lot better (see image below). It's pretty rough, but if you like what you see, I would be happy to work on it more and provide variations for Windows and Linux.
Before
After
bpmct, gyzerok and kylecarbs
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Relationships
Development
Select code repository
Activity
nhooyr commentedon Nov 16, 2020
I agree, the current icon is kinda weird. Love the new icon @christianjuth!
The files that would need replacing are in https://github.com/cdr/code-server/tree/master/src/browser/media
If you can open a PR with the new files, I'd be happy to accept as is! What were you thinking of changing for Linux/Windows?
christianjuth commentedon Nov 16, 2020
@nhooyr to be completely honest, I haven't installed code-server on Linux/Windows as a PWA. Now that I'm looking at the current icons, it looks like it uses the same icons for all platforms. Do you think the design above works for Linux/Windows? I want to make sure I'm not only thinking of Mac since that is what I use day-to-day.
Also, is there a place in the project I can put the SVG file? That will make it easier to change the icon later. Should I throw it in the same folder you mentioned above? I'm using Sketch, so I could also include the project file if you want.
nhooyr commentedon Nov 18, 2020
I think it should work. Though, I did just notice that you didn't use our exact logo. Let me see if I can get our logo as an SVG from our designer.
Yes, please include both. I think we'll want to use https://git-lfs.github.com though
nhooyr commentedon Nov 19, 2020
Got the icon.
https://drive.google.com/file/d/1k4Tsb-4e5o5ZYGlOFLJfFdmzAoG962Oi/view?usp=sharing
Revamp icons
Revamp icons
Revamp icons
Revamp icons
Revamp icons
Revamp icons (#2383)
nhooyr commentedon Dec 1, 2020
Will be in the next release!
sync with upstream (#1)