Skip to content

Update Dock Icon #2307

@christianjuth

Description

@christianjuth

Update Dock Icon

I want to prefix this with this is super nitpicky. I love code-server, but the current dock icon stands out from other applications in the dock in an unpleasant way. I reworked the current design to match the macOS Big Sur icon style, and I think it looks a lot better (see image below). It's pretty rough, but if you like what you see, I would be happy to work on it more and provide variations for Windows and Linux.

Before

image

After

icon in dock

Full icon

Activity

added this to the v3.7.1 milestone on Nov 16, 2020
nhooyr

nhooyr commented on Nov 16, 2020

@nhooyr
Contributor

I agree, the current icon is kinda weird. Love the new icon @christianjuth!

The files that would need replacing are in https://github.com/cdr/code-server/tree/master/src/browser/media

If you can open a PR with the new files, I'd be happy to accept as is! What were you thinking of changing for Linux/Windows?

christianjuth

christianjuth commented on Nov 16, 2020

@christianjuth
Author

@nhooyr to be completely honest, I haven't installed code-server on Linux/Windows as a PWA. Now that I'm looking at the current icons, it looks like it uses the same icons for all platforms. Do you think the design above works for Linux/Windows? I want to make sure I'm not only thinking of Mac since that is what I use day-to-day.

Also, is there a place in the project I can put the SVG file? That will make it easier to change the icon later. Should I throw it in the same folder you mentioned above? I'm using Sketch, so I could also include the project file if you want.

nhooyr

nhooyr commented on Nov 18, 2020

@nhooyr
Contributor

@nhooyr to be completely honest, I haven't installed code-server on Linux/Windows as a PWA. Now that I'm looking at the current icons, it looks like it uses the same icons for all platforms. Do you think the design above works for Linux/Windows? I want to make sure I'm not only thinking of Mac since that is what I use day-to-day.

I think it should work. Though, I did just notice that you didn't use our exact logo. Let me see if I can get our logo as an SVG from our designer.

Also, is there a place in the project I can put the SVG file? That will make it easier to change the icon later. Should I throw it in the same folder you mentioned above? I'm using Sketch, so I could also include the project file if you want.

Yes, please include both. I think we'll want to use https://git-lfs.github.com though

added 2 commits that reference this issue on Nov 30, 2020
a3aea57
914ccd7
added 4 commits that reference this issue on Nov 30, 2020
445a5f8
10aa05a
1d9f57c
ebe4d7e
nhooyr

nhooyr commented on Dec 1, 2020

@nhooyr
Contributor

Will be in the next release!

modified the milestones: v3.7.5, v3.7.4 on Dec 1, 2020
added a commit that references this issue on Jan 12, 2021
c21b72a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @christianjuth@nhooyr

        Issue actions

          Update Dock Icon · Issue #2307 · coder/code-server