Skip to content

[Feat]: Support for older browsers (ios 12) #4785

Open
@wiegell

Description

@wiegell

ES2020 is a showstopper for some older browsers e.g. all IOS 12 devices (original iPad air in my case). Safari chokes on optional chaining (?.)

ES6 compile was tested in coder/vscode#23, but then removed again in #d4f09b4.
Any plans to reinstate ES6?

For other people on ios 12, the latest code-server still on ES6 (before microsoft bumped vscode to ES2020) is code-server@3.10.2

Activity

jsjoeio

jsjoeio commented on Jan 24, 2022

@jsjoeio
Contributor

I don't think so unfortunately. We did test it but then had to remove it because it broke Jupyter Notebooks. I don't know if there's a solution that doesn't cause something to break. If you ideas though, we'd be open to it

wiegell

wiegell commented on Jan 26, 2022

@wiegell
Author

What about an argument for the install script that gives the option of building with ES6?

jsjoeio

jsjoeio commented on Jan 26, 2022

@jsjoeio
Contributor

I like the sound of that! But my concern is then we'd be shipping a version of code-server that only partially works since Jupyter Notebooks would be broken. We'd also have to maintain an additional set of binaries, right?

A couple options:

  • I wonder if we could add an option to the install script called "build from source" which could take a config where you could specify "bundle with ES6
  • you could fork code-server, make the changes in your fork and then create a build yourself (easiest, preferred solution)
wiegell

wiegell commented on Jan 26, 2022

@wiegell
Author

Option one is the neatest while option two might be the easiest. I think it would be ok with some stuff not working as long as the user is sufficiently warned.
My personal incentive have waned, since i now bought a newer tablet. Maybe the issue should just linger to see if its worth the effort?

jsjoeio

jsjoeio commented on Jan 27, 2022

@jsjoeio
Contributor

My personal incentive have waned, since i now bought a newer tablet. Maybe the issue should just linger to see if its worth the effort?

Haha definitely! I'll add it to the Backlog Candidates.

added this to the Backlog Candidates milestone on Jan 27, 2022
helojo

helojo commented on Apr 1, 2022

@helojo

is the same problem? my iPad os version is iOS 13.
when I open the url on the ipad browser, there is no any display, and the screen is always white after input the password.But it's ok on Macos or windows.Has anyone else encountered this problem?

IMG_E9AAAA813D13-1

wiegell

wiegell commented on Apr 1, 2022

@wiegell
Author

is the same problem? my iPad os version is iOS 13.

when I open the url on the ipad browser, there is no any display, and the screen is always white after input the password.But it's ok on Macos or windows.Has anyone else encountered this problem?

IMG_E9AAAA813D13-1

As mentioned above - revert to 3.10.2

helojo

helojo commented on Apr 1, 2022

@helojo

As mentioned above - revert to 3.10.2

@wiegell thank you,I will upgrade iOS to 15.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementSome improvement that isn't a feature

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @jsjoeio@helojo@wiegell

        Issue actions

          [Feat]: Support for older browsers (ios 12) · Issue #4785 · coder/code-server