Skip to content

feat(inline-tools): Inline tools rendered as popover #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 128 commits into from
Jun 30, 2024

Conversation

TatianaFomina
Copy link
Contributor

@TatianaFomina TatianaFomina commented May 11, 2024

New Inline Tools

Inline tools now use popover as well as Toolbox and Block Tunes 💪

image

What's done

  • PopoverInline class added. It extends PopoverDesktop but makes it horizontal (and adds few features)
  • Popover styles are updated
  • Removed redundant styles

ToDo

  • Tests
  • Rewrite built-in inline tools to new api

@TatianaFomina TatianaFomina force-pushed the feat/popover-horizontal branch from c8479e7 to 94232ea Compare May 11, 2024 15:10
@TatianaFomina TatianaFomina requested a review from neSpecc June 29, 2024 18:49
@TatianaFomina TatianaFomina requested a review from neSpecc June 30, 2024 11:43
@TatianaFomina TatianaFomina merged commit 439658a into next Jun 30, 2024
6 checks passed
@neSpecc neSpecc deleted the feat/popover-horizontal branch June 30, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants