Skip to content

Added Cartesian tree #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Disha5harma
Copy link

References to other Issues or PRs or Relevant literature

Brief description of what is fixed or changed

Other comments

@czgdp1807
Copy link
Member

Please do not open new PRs for adding new commits. You can simply push the changes to di5hasharma(your working branch), the PR will be automatically updated.

@czgdp1807
Copy link
Member

Ah! I see that earlier PR was closed by me. However, the changes here don't look good either. I'd suggest to take some time and understand the pattern we follow for coding out data structures and then make a PR. The code in your diff doesn't align with what we usually do. Add proper doc strings to each method and tests in the test file.

@robotjellyzone
Copy link

Also, @Disha5harma you need to fill up that template when you create a PR where you need to reference an issue number. IF you are confused with creating PR then just follow our PR policy How-to-contribute and More about here at wiki

@czgdp1807 czgdp1807 added invalid This doesn't seem right trees gssoc20 labels Mar 22, 2020
@Disha5harma
Copy link
Author

Disha5harma commented Mar 22, 2020 via email

@czgdp1807
Copy link
Member

Closing in favour of #235

@czgdp1807 czgdp1807 closed this Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right trees
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants