-
Notifications
You must be signed in to change notification settings - Fork 312
Binary tree test with inorder and postorder #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary tree test with inorder and postorder #298
Conversation
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
=========================================
Coverage 98.789% 98.789%
=========================================
Files 23 23
Lines 2809 2809
=========================================
Hits 2775 2775
Misses 34 34 |
Replacing will be better since both types of tests are checking the same thing. |
@@ -19,10 +19,24 @@ def test_BinarySearchTree(): | |||
b.insert(7, 7) | |||
b.insert(14, 14) | |||
b.insert(13, 13) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert ['(None, 1, 1, None)', '(None, 4, 4, None)', | ||
'(None, 7, 7, None)', '(5, 6, 6, 6)', '(3, 3, 3, 4)', '(None, 13, 13, None)', | ||
'(8, 14, 14, None)','(None, 10, 10, 7)','(1, 8, 8, 2)'] == [str(x) for x in postorder] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the pattern as in here, https://github.com/MuskanPaliwal/pydatastructs/pull/4/files#diff-25976db10a639fd586c15d82e39d8dd8R455-R459
Closing in favour of #304 |
References to other Issues or PRs or Relevant literature
Fixes #294
Brief description of what is fixed or changed
instead of replacing I added them inside the already created test