Skip to content

Longest increasing subsequence added #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 6, 2021

Conversation

sHiVaNgI821
Copy link
Contributor

Added the longest_increasing_subsequence method that returns the longest strictly increasing subsequence that can be obtained from the given array. The lower_bound function used in the implementation has been taken from #351

References to other Issues or PRs or Relevant literature

Brief description of what is fixed or changed

Other comments

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #364 (cb73fc2) into master (0f23c98) will increase coverage by 0.009%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master      #364       +/-   ##
=============================================
+ Coverage   98.574%   98.583%   +0.009%     
=============================================
  Files           25        25               
  Lines         3297      3319       +22     
=============================================
+ Hits          3250      3272       +22     
  Misses          47        47               
Impacted Files Coverage Δ
pydatastructs/linear_data_structures/__init__.py 100.000% <ø> (ø)
pydatastructs/linear_data_structures/algorithms.py 99.678% <100.000%> (+0.024%) ⬆️

Impacted file tree graph

@Smit-create
Copy link
Member

@sHiVaNgI821 Please resolve merge conflicts since your previous PR has merged.

@Smit-create Smit-create added level2 and removed level3 labels May 15, 2021
@Smit-create
Copy link
Member

@czgdp1807 Please have a look

@czgdp1807
Copy link
Member

Seems good. Would prefer to use, snake case instead of camel case in the doc string examples.

@Smit-create
Copy link
Member

Looks ready to be merged.

@czgdp1807
Copy link
Member

Will merge once the tests pass.

@czgdp1807 czgdp1807 merged commit 0edbada into codezonediitj:master Jun 6, 2021
@czgdp1807
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants