Skip to content

Modified Error messages #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Modified Error messages #411

merged 2 commits into from
Oct 11, 2021

Conversation

pratikgl
Copy link
Member

Modified error messages and made them more clear

References to other Issues or PRs or Relevant literature

The previous error messages were quite vague which pretty much said: "something went wrong". I have made changes in the error message so the user would know what exactly went wrong.

Brief description of what is fixed or changed

For example instead of saying 1D array cannot be created due to incorrect information it would now say Data type is not defined or Too few arguments to create a 1D array, pass either size of the array or list of elements or both.

Other comments

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #411 (dc98ba4) into master (f391ab6) will increase coverage by 0.001%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master      #411       +/-   ##
=============================================
+ Coverage   98.620%   98.622%   +0.001%     
=============================================
  Files           26        26               
  Lines         3407      3411        +4     
=============================================
+ Hits          3360      3364        +4     
  Misses          47        47               
Impacted Files Coverage Δ
pydatastructs/linear_data_structures/arrays.py 100.000% <100.000%> (ø)

Impacted file tree graph

@czgdp1807 czgdp1807 merged commit a158395 into codezonediitj:master Oct 11, 2021
@czgdp1807
Copy link
Member

Thanks @pratikgl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants