Skip to content

Azure Container App one click deployment #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 4, 2024

Conversation

EugeneLightsOn
Copy link
Collaborator

@EugeneLightsOn EugeneLightsOn commented Jun 3, 2024

  • Toolkit deployment to Azure Container App. This deployment type uses connection to an external DB and supports horizontal autoscaling.

AI Description

This PR introduces a new configuration for deploying the Cohere Toolkit to Microsoft Azure Platform using Azure Container App. It also updates the existing Azure deployment method, which uses Azure Container Instances.

Summary of Changes

  • Adds a new configuration for deploying the Cohere Toolkit to Azure using Azure Container App.
  • Updates the existing Azure deployment method, which uses Azure Container Instances, with a new button link and deployment instructions.
  • Modifies the poetry install command in the Dockerfile to include the --without-setup flag.
  • Introduces a new workflow file, build_and_push_docker_proxy.yml, for creating and publishing a single container image with an nginx proxy.

Detailed Changes

  • New Azure Container App Deployment: A new configuration has been added to deploy the Cohere Toolkit to Azure using Azure Container App. This provides an alternative deployment method with potential benefits such as improved scalability and resource management.
  • Azure Container Instances Deployment Update: The existing Azure deployment method, which uses Azure Container Instances, has been updated. The button link and deployment instructions have been modified to match the new Azure Container App deployment.
  • Dockerfile Modification: In the Dockerfile, the poetry install command has been updated to include the --without-setup flag. This flag is used to skip the installation of the setuptools package, which may not be required for all projects.
  • New Workflow File: A new workflow file, build_and_push_docker_proxy.yml, has been introduced. This file defines a GitHub Actions workflow for creating and publishing a single container image with an nginx proxy. The workflow includes steps for checking out the repository, logging into the container registry, building and pushing the Docker image, and testing the image.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@d089057). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage        ?   87.90%           
=======================================
  Files           ?      114           
  Lines           ?     3662           
  Branches        ?        0           
=======================================
  Hits            ?     3219           
  Misses          ?      443           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tianjing-li tianjing-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks Eugene

@EugeneLightsOn EugeneLightsOn merged commit f5ad3ee into main Jun 4, 2024
2 checks passed
@EugeneLightsOn EugeneLightsOn deleted the eugene/EXT2-69_azure_hpa branch June 4, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants