Fix a regression in recursive dependency enumeration #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two bugs in a previous change to recursive dependency enumeration. The first relates specifically to defaultdict behaviors, and the other to lambda capture. Fixes 520052d
This was referenced May 29, 2025
Comment on lines
+117
to
+118
| non_map_categories = recursive_categories | ||
| recursive_categories = defaultdict(lambda: non_map_categories) |
There was a problem hiding this comment.
Reading up on lambda captures, you might be able to do this (pardon the line length):
Suggested change
| non_map_categories = recursive_categories | |
| recursive_categories = defaultdict(lambda: non_map_categories) | |
| recursive_categories = defaultdict(lambda recursive_categories=recursive_categories: recursive_categories) |
but it's not really better than the current solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two bugs in a previous change to recursive dependency enumeration. The first relates specifically to
defaultdictbehaviors, and the other to lambda capture.Fixes #646
Keeping in draft until I can add tests.
CI is blocked on colcon/ci#40