-
Notifications
You must be signed in to change notification settings - Fork 643
[OPIK-2227]: Make table columns independently resizable #2318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[OPIK-2227]: Make table columns independently resizable #2318
Conversation
Hey @infinitespark-96 , Thank you for your contribution. I have run code with your improvements, and I see that the table layout is broken. We want to preserve a good UI while introducing the functionality to define column widths for each column. To achieve this, the following steps should be taken: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table layout should remain the same as was before the change.
…dd responsive auto-width filler, and update grouped row logic
I've made the requested changes fixes and improvements. IMO, it looks good now, and the main issues addressed in issue #2227 are now fixed. If there are any additional improvements maybe better to make a separate ticket for this? Screencast: https://github.com/user-attachments/assets/e066bc70-2e02-4626-95e4-ce3220a3d3ea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @infinitespark-96, thank you for your contribution!
From a technical perspective, your code looks solid. We’re currently having internal discussions with the product team about whether we want to introduce such a drastic change to the table layout.
There’s also an issue with some tables where column titles are being trimmed by default — we’ll need to address that.
Additionally, I suggest the following change in the DataTable file: remove the calculation of the auto column’s width and delegate that responsibility to the browser instead.
I recommend pausing on this until the product team has made a decision on how to proceed.
Got it, thanks for the review @andriidudar |
Details
Issues
Changing the width of one column changes the width of all other columns.
Plus It's also hard to resize the last column in the table.
Resolves #2227
How it was before: https://github.com/user-attachments/assets/3761996a-353c-4fea-b50c-c5ab4a400df6
And how it is now:https://github.com/user-attachments/assets/ae2ef936-5463-4582-8938-e2bb6b5cd863