-
Notifications
You must be signed in to change notification settings - Fork 643
[OPIK-1512]: [SDK] Long running jobs span start and end batch creation with feature flag #2387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yaricom
wants to merge
24
commits into
OPIK-1511-long-running-traces
Choose a base branch
from
OPIK-1512-long-running-spans
base: OPIK-1511-long-running-traces
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[OPIK-1512]: [SDK] Long running jobs span start and end batch creation with feature flag #2387
yaricom
wants to merge
24
commits into
OPIK-1511-long-running-traces
from
OPIK-1512-long-running-spans
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for improved parameter handling; updated OpikClient and decorator logic to support logging of span start and end based on configuration.
…ce start based on configuration across integrations.
SDK Unit Tests Results600 tests 595 ✅ 29s ⏱️ For more details on these failures, see this check. Results for commit cc8e061. ♻️ This comment has been updated with latest results. |
…nd `_after_call` into dedicated methods with enhanced exception handling and error logging.
…nclude `deprecated`
…tion and improve maintainability. Added support for attachments during span creation and updated tests accordingly.
…ng consistency, and refactored attachment handling logic in span creation. Updated associated tests.
…t_name` in span creation by OpikClient.
…se it results in weird behavior.
…ted end time handling in `fake_message_factory`.
…` to use `_start_span` and `_start_trace` methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The Python SDK needs to support the ingestion of long running jobs, for instance taking 500 seconds.
For that:
For these two operations, It will use the batch createSpans endpoint as an upsert endpoint, by providing a proper timestamp in the last_updated_at field for all spans on each of those calls.
After this PR, the following code snippet will send the spans batch to the server exactly as provided.
The spans batch sent to server as result of the code snippet execution:
The traces batch sent to server:
Issues
Resolves #1610
Testing
Implemented related test cases.