Skip to content

ui: Enhance URL Handling to Support Partial Inputs #30681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 27, 2023

Conversation

royjr
Copy link
Contributor

@royjr royjr commented Dec 11, 2023

Implemented a regex-based enhancement in the download function to support shorthand URL inputs. This update allows users to input URLs in the format commaai/master-ci, which the system will automatically interpret as https://installer.comma.ai/commaai/master-ci. This improvement streamlines user interaction by allowing more flexible URL formats, enhancing usability for both new and experienced users.

  1. Checks URLs against a specific pattern: two segments separated by a slash, with the stipulation that the first segment does not include a period. This ensures accurate interpretation of shorthand URLs.
  2. Automatically prepends https://installer.comma.ai/ to these shorthand inputs, ensuring seamless integration with our existing URL processing workflow.
  • test regex expression
  • test on device

Thanks to Jacob Pfeifer for the feature request!

@github-actions github-actions bot added the ui label Dec 11, 2023
@royjr royjr marked this pull request as draft December 11, 2023 06:49
@adeebshihadeh
Copy link
Contributor

No need to test on device. setup runs on PC

@royjr royjr marked this pull request as ready for review December 19, 2023 01:20
@adeebshihadeh adeebshihadeh merged commit 4df8506 into commaai:master Dec 27, 2023
@royjr royjr deleted the easy-url branch December 27, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants