Skip to content

Bump failing after upgrade from 0.16.0 -> 0.16.1 #58

@victorbadenas

Description

@victorbadenas

After release 0.16.1 with the fix for git safe directories was added, the base image's python version was bumped as well and was not reflected in the changelog.

When using custom-made packages inside of the docker image, this version can cause breakage in pipelines.

Is making the python version of the action configurable a desireable feature?

Activity

woile

woile commented on Feb 6, 2023

@woile
Member

Can you explain a bit more what are you using this action dockerfile for? Could you show an example? As of now I wouldn't recommend using the docker image of this action

victorbadenas

victorbadenas commented on Feb 6, 2023

@victorbadenas
Author

Thanks @woile for the quick reply! I'm not using the Docker directly but rather through the action. Basically having a:

    - uses: commitizen-tools/commitizen-action@0.16.1
      with:
        extra_requirements: my_package

where my_package is a custom package which contains an inheritance of commitizen.cz.base.BaseCommitizen with some custom functionalities. If any of the functionalities in the extra_requirements packages are incompatible with the python version installed in the docker image (3.11 in this case), it makes this tool unusable for its purpose. In this regard, the previous version, which was using python 3.8 had the same issue, but it was not apparent to me.

NOTE: I cannot roll-back either as 0.16.0 does not have the safe directories fix.

woile

woile commented on Feb 6, 2023

@woile
Member

I see, let me see if I can rollback the image to 3.8. It is possible that the libraries are missing other packages to compile. could you share the error you get?

woile

woile commented on Feb 6, 2023

@woile
Member

Please let me know if it works (sorry it was automatically closed 😅 )
Use version 0.16.2

victorbadenas

victorbadenas commented on Feb 6, 2023

@victorbadenas
Author

I will try as soon as possible. Thank you very much for the quick rollback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @woile@victorbadenas

      Issue actions

        Bump failing after upgrade from 0.16.0 -> 0.16.1 · Issue #58 · commitizen-tools/commitizen-action