You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After release 0.16.1 with the fix for git safe directories was added, the base image's python version was bumped as well and was not reflected in the changelog.
When using custom-made packages inside of the docker image, this version can cause breakage in pipelines.
Is making the python version of the action configurable a desireable feature?
Can you explain a bit more what are you using this action dockerfile for? Could you show an example? As of now I wouldn't recommend using the docker image of this action
where my_package is a custom package which contains an inheritance of commitizen.cz.base.BaseCommitizen with some custom functionalities. If any of the functionalities in the extra_requirements packages are incompatible with the python version installed in the docker image (3.11 in this case), it makes this tool unusable for its purpose. In this regard, the previous version, which was using python 3.8 had the same issue, but it was not apparent to me.
NOTE: I cannot roll-back either as 0.16.0 does not have the safe directories fix.
I see, let me see if I can rollback the image to 3.8. It is possible that the libraries are missing other packages to compile. could you share the error you get?
Activity
woile commentedon Feb 6, 2023
Can you explain a bit more what are you using this action dockerfile for? Could you show an example? As of now I wouldn't recommend using the docker image of this action
victorbadenas commentedon Feb 6, 2023
Thanks @woile for the quick reply! I'm not using the Docker directly but rather through the action. Basically having a:
where
my_package
is a custom package which contains an inheritance ofcommitizen.cz.base.BaseCommitizen
with some custom functionalities. If any of the functionalities in theextra_requirements
packages are incompatible with the python version installed in the docker image (3.11
in this case), it makes this tool unusable for its purpose. In this regard, the previous version, which was using python 3.8 had the same issue, but it was not apparent to me.NOTE: I cannot roll-back either as 0.16.0 does not have the safe directories fix.
woile commentedon Feb 6, 2023
I see, let me see if I can rollback the image to 3.8. It is possible that the libraries are missing other packages to compile. could you share the error you get?
woile commentedon Feb 6, 2023
Please let me know if it works (sorry it was automatically closed 😅 )
Use version
0.16.2
victorbadenas commentedon Feb 6, 2023
I will try as soon as possible. Thank you very much for the quick rollback!