You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Yes, sorry I noticed that.
I think I will revert the change (tomorrow) and provide a more robust approach.
In fact we have a design flaw to fix: the way we are handling --changelog-to-stdout on the bump command we can't have both dry-run, incremental and changelog_hook at the same time
Activity
woile commentedon Mar 13, 2024
Good point, thanks for raising the issue, we'll take a look tomorrow. @noirbizarre any thoughts what could've been the issue? Thanks
fix(changelog): include latest change when dry run and incremental
fix(changelog): include latest change when dry run and incremental
fix(changelog): include latest change when dry run and incremental
fix(changelog): include latest change when dry run and incremental
woile commentedon Mar 14, 2024
A FIX is on its way, awaiting for @noirbizarre
noirbizarre commentedon Mar 14, 2024
Yes, sorry I noticed that.
I think I will revert the change (tomorrow) and provide a more robust approach.
In fact we have a design flaw to fix: the way we are handling
--changelog-to-stdout
on thebump
command we can't have both dry-run, incremental and changelog_hook at the same timewoile commentedon Mar 14, 2024
I made a PR: #1026 I think to patch this issue it works, but fill free to send more commits to that PR
fix(changelog): include latest change when dry run and incremental
woile commentedon Mar 14, 2024
Please confirm if it's working now, 🙏🏻
edgarrmondragon commentedon Mar 14, 2024
@woile I can confirm only the increment is generated when using 3.18.4 🎉. Thanks for the quick turnaround!