Skip to content

Conversation

@hez2010
Copy link
Contributor

@hez2010 hez2010 commented Dec 3, 2025

Adding new compilers for .NET.

Copilot AI review requested due to automatic review settings December 3, 2025 15:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Build Required

The following additions require CE to build artifacts before deployment:

  • dotnet.yaml: compilers/dotnet/newer v10.0.0 (type: s3tarballs)
  • dotnet.yaml: compilers/dotnet/newer v9.0.11 (type: s3tarballs)
  • dotnet.yaml: compilers/dotnet/newer v8.0.22 (type: s3tarballs)

Please ensure these have been built and uploaded to S3 before merging, or coordinate with the CE team.

Build Commands

gh workflow run bespoke-build.yaml -f image=dotnet -f version=v10.0.0 -f command=build.sh
gh workflow run bespoke-build.yaml -f image=dotnet -f version=v9.0.11 -f command=build.sh
gh workflow run bespoke-build.yaml -f image=dotnet -f version=v8.0.22 -f command=build.sh

@mattgodbolt
Copy link
Member

Running builds...

Copy link
Member

@mattgodbolt mattgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. sorry for the slow reponse

@mattgodbolt
Copy link
Member

Builds are failing due to:

    Restored /root/dotnet/runtime/src/coreclr/tools/dotnet-pgo/dotnet-pgo.csproj (in 15.56 sec).
  
  Build FAILED.
  
  /root/dotnet/runtime/src/coreclr/tools/r2rtest/R2RTest.csproj : error NU1903: Warning As Error: Package 'Microsoft.Build' 17.8.3 has a known high severity vulnerability, https://github.com/advisories/GHSA-w3q9-fxm7-j8fq [/root/dotnet/runtime/Build.proj]
  /root/dotnet/runtime/src/coreclr/tools/aot/ILCompiler.Build.Tasks/ILCompiler.Build.Tasks.csproj : error NU1903: Warning As Error: Package 'Microsoft.Build.Utilities.Core' 17.8.3 has a known high severity vulnerability, https://github.com/advisories/GHSA-w3q9-fxm7-j8fq [/root/dotnet/runtime/Build.proj]
      0 Warning(s)
      2 Error(s)

:(

@hez2010
Copy link
Contributor Author

hez2010 commented Dec 10, 2025

It seems that we need to switch to 10.0.1 instead, as 10.0.0 has dependencies that have security vulnerabilities. I don't have a PC to work on this right now, if you would like, could you help me bump the version v10.0.0 to v10.0.1?

@hez2010
Copy link
Contributor Author

hez2010 commented Dec 10, 2025

Sorry, seems that v10.0.1 has the same issue. We will have to wait for the next patch release of .NET 10.

@mattgodbolt
Copy link
Member

I'm not sure it's just that - 8.0.22 and 9.0.11 also failed too

@mattgodbolt mattgodbolt added the do-not-merge Changes are not ready to be merged yet label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Changes are not ready to be merged yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants