Skip to content

Chore: rename compose app service #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM caltrans/pems:app
FROM caltrans/pems:web

COPY . .

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tests-ui.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
- name: Check out code
uses: actions/checkout@v4

- name: Start app
- name: Start web app
run: |
cp .env.sample .env
docker compose up --detach app
docker compose up --detach web

- name: Run Lighthouse tests for a11y
uses: treosh/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion bin/build.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash
set -eux

docker compose build app
docker compose build web

docker compose build dev

Expand Down
4 changes: 2 additions & 2 deletions compose.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: pems

services:
app:
web:
build:
context: .
dockerfile: appcontainer/Dockerfile
image: caltrans/pems:app
image: caltrans/pems:web
env_file: .env
ports:
- "${DJANGO_LOCAL_PORT:-8000}:8000"
Expand Down
2 changes: 1 addition & 1 deletion docs/development/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ Feel free to inspect the environment file, but leave the defaults for now.
Start the application service with Compose:

```shell
docker compose up -d app
docker compose up -d web
```

The `-d` flag starts the service in "detatched" mode, so your terminal is still available for additional commands. Without this flag, your terminal attaches to the service container's standard output.
Expand Down
Loading