Skip to content

build: Use the setup-build action in swift-toolchain #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Steelskin
Copy link
Collaborator

  • Use the setup-build action in every job.
  • Move the build machine setup to the beginning of the job as this saves time when it fails.
  • Remove WORKAROUND_WINDOWS_SDK_VERSION for the smoke tests, they should test the latest Windows SDK version.

@Steelskin Steelskin requested a review from compnerd June 2, 2025 18:02
@Steelskin
Copy link
Collaborator Author

I ran this build with these changes last week: https://github.com/thebrowsercompany/swift-build/actions/runs/15357521575
You can ignore the failure, it fails to set the release as expected as this was a manually triggered build.

repository: swiftlang/swift-toolchain-sqlite
ref: ${{ inputs.swift_toolchain_sqlite_revision }}
path: ${{ github.workspace }}/SourceCache/swift-toolchain-sqlite
path: ${{ github.workspace }}/SourceCache/gha-swift-build
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about calling this ci-build instead of gha-swift-build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants