Skip to content

Fluent context menu #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2023
Merged

Fluent context menu #22

merged 4 commits into from
May 5, 2023

Conversation

Sanlorng
Copy link
Collaborator

New ContextMenu Visual

  1. Before
    image

  2. After
    image

New Component: FontIcon

  1. Requirement: JVM platfrom and installed Segoe Fluent Icons font.
    image

@Sanlorng Sanlorng changed the base branch from master to dev April 30, 2023 15:58
@Konyaco Konyaco merged commit 01b6209 into dev May 5, 2023
@Sanlorng Sanlorng deleted the fluent_context_menu branch May 6, 2023 15:18
@Konyaco Konyaco restored the fluent_context_menu branch May 6, 2023 16:54
@Konyaco
Copy link
Collaborator

Konyaco commented May 6, 2023

I reverted this PR because DropdownMenu cannot be compiled on the Android platform. The context menu is implemented by the more basic component - Flyout, not the DropdownMenu. Maybe we can delay this until we have made the Flyout surface?
Additionally, I think providing Windows-only components might not be a good idea.

@Sanlorng
Copy link
Collaborator Author

Sanlorng commented May 7, 2023

Additionally, I think providing Windows-only components might not be a good idea.

This feature depends on Compose Desktop ,Android not included ContextMenuRepresentation,Android' Text ContextMenu depends on SelectTextToolbar,which is internal feature in Jetpack Compose.

@Konyaco
Copy link
Collaborator

Konyaco commented May 7, 2023

Additionally, I think providing Windows-only components might not be a good idea.

This feature depends on Compose Desktop ,Android not included ContextMenuRepresentation,Android' Text ContextMenu depends on SelectTextToolbar,which is internal feature in Jetpack Compose.

I mean the FontIcon component. If it's only used in ContextMenu, that would be acceptable. Please forgive me for not having much free time to work on this project.

@Sanlorng
Copy link
Collaborator Author

Sanlorng commented May 7, 2023

Additionally, I think providing Windows-only components might not be a good idea.

This feature depends on Compose Desktop ,Android not included ContextMenuRepresentation,Android' Text ContextMenu depends on SelectTextToolbar,which is internal feature in Jetpack Compose.

I mean the FontIcon component. If it's only used in ContextMenu, that would be acceptable. Please forgive me for not having much free time to work on this project.

FontIcon component need Seoge Fluent Icon Font,I implement it that depends on AWT' Font manager , if you want it can be used in Android ,before that, we should think about whether the font is installed on Android. This component should used with Icon component. Icon component is a fallback component when target platform not installed Seoge Fluent Icon (See FluentContextMenuRepresentation).

@Sanlorng Sanlorng deleted the fluent_context_menu branch November 2, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants