-
-
Notifications
You must be signed in to change notification settings - Fork 61
Build with Python ABI3 to reduce build matrix #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14636489353. Examine the logs at this URL for more detail. |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2025.04.23.13.34.55
Linux builds are failing with:
It seems like |
Beside the test error in conda-build, I think we also need to revise the build strings to reflect the abi3 use, as encoding the python version is the build string may now be misleading. |
Actually that is still what is done by abi3 builds, see for example https://conda-metadata-app.streamlit.app/?q=conda-forge%2Flinux-64%2Fpolars-1.27.1-py39h2a4a510_3.conda and https://conda-metadata-app.streamlit.app/?q=conda-forge%2Flinux-64%2Fatomic-counter-0.1.4-py39h677e893_2.conda . So that is good to go, for consistency with other builds. |
By reading https://conda.org/learn/ceps/cep-0020/, I wonder if it is possible at all to use |
I think we can proably finally use the include/exclude |
and then 6 years later, you may finally be able to update the comment at the top so that the package split makes sense! |
So you suggest to move the Python files out of |
Yes. Ultimate What I did 7 years ago was a hack because of the complications of compiling opencv. This abi3 might be what opens up the possibility to move away from it in a sane way. |
Fix #466 .
More details on the used
PYTHON3_LIMITED_API
CMake option:Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)