Launched plugins Stdout/Stderr are dropped

[champtar]

nri/pkg/adaptation/plugin.go

Line 119 in 6f5a4d2

cmd := exec.Command(filepath.Join(dir, name))

cmd.Stdout/Stderr are nil, so everything goes to /dev/null

[klihub]

nri/pkg/adaptation/plugin.go

Line 119 in 6f5a4d2

cmd := exec.Command(filepath.Join(dir, name))

cmd.Stdout/Stderr are nil, so everything goes to /dev/null

This was a conscious choice to avoid, for instance, proxying log messages through the runtime. The idea was that the plugins will set up and take care of their own logging using syslog(3).

We can update the stub so that it automatically sets up logging via syslog, when the plugin is launched by the runtime.

[champtar]

The big limitation of using syslog is that panic text is not logged, or at least need some more work (in 1.23 we will have SetCrashOutput)

[champtar]

Or you mean redirecting stdout / stderr to syslog in plugin.go and not in each plugins ?

[klihub]

Or you mean redirecting stdout / stderr to syslog in plugin.go and not in each plugins ?

No, I mean in the pkg/stub, which is then on the plugin side...

[samuelkarp]

Either the stub needs to set something up, or we should have something handle stdout/stderr streams in the framework. I've marked this as required for 1.0 since I think that not having logging is a pretty big gap.