Skip to content

Conversation

@klihub
Copy link
Member

@klihub klihub commented Jan 12, 2026

This PR

  • fixes the collection of sysctl adjustment to avoid a crash due to assignment to uninitialized maps
  • adds a minimal unit test for adjusting sysctl settings
  • fixes adjustment stripping for sysctls

Initilize sysctl map before collecting results. Failing to do
so results in a crash if any plugin adjusts sysctls.

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub requested review from mikebrow and samuelkarp January 12, 2026 17:24
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelkarp samuelkarp merged commit bc2f819 into containerd:main Jan 12, 2026
16 checks passed
@klihub klihub deleted the fixes/sysctl-adjustment branch January 13, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants