Open
Description
More complex alternative of #835.
Abstract
Currently the scrollback buffer size is an explicit hard limit, which means that in case multiple long commands exceed the limit, the top of the buffer is cleared, potentially resulting in one command's output being cleared partially. Instead, if the shell integration is enabled and Contour has tracked where the prompts are in the scrollback, the clearing should be done for one atomic unit of executed command-line, not in a way that it "cuts" the history in the "middle".
Motivation
C++ SFINAE outputs.
Specification
- If Contour does not detect prompt markers in the VT buffer, this feature should be skipped due to unreliable output.
history.limit
should have asoft
and ahard
key.- Assume that
X
,Y
,Z
andα
are prompt markers, in the presented order, with the following constraints:X
is the line where the oldest visible prompt is now beyond thesoft
limit,Y
is the second oldest, beyond thesoft
limit, andZ
is a prompt still visible after a hypothetical clearing (so it's line is between(-∞, Soft)
)α
is a prompt that is newer thanZ
.
- The range
[X, Y)
should be cleared (as it exceeded the requested history size), but[Y, Z)
should not.- Current behaviour:
[X, Soft]
is cleared, and only(Soft, Z]
and[Z, ∞)
remain. - This should happen even if all the remaining scrollback buffer would not be exactly the requested history size.
- Current behaviour:
- Once
Z
reaches thesoft
limit and the entire range[Z, α)
is beyond thesoft
limit, the entire range is cleared. - The
hard
limit should be there to prevent memory overflows. It could be user-configurable, with twice thesoft
limit being a good default. If thehard
limit is reached, lines are cleared no matter what.
Expected outcome: as long as the terminal does not exceed the hard
limit, the oldest line in the scrollback buffer is a proper prompt, with the full output of said command.