caching bucket for parquet chunks file #6805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yeya24 <[email protected]>
Signed-off-by: yeya24 <[email protected]>
yeya24
force-pushed
the
cache-parquet-chunks
branch
from
3db4282 to
8864dec
Compare
Signed-off-by: yeya24 <[email protected]>
Signed-off-by: yeya24 <[email protected]>
|
Thanks! Amazing work! |
alanprot
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Enable caching bucket for Parquet queryable. The main benefit is to enable parquet chunks cache. I am able to see reduction on S3 calls, mainly S3 GetRange requests on parquet querier and some CPU usage reduction.
Chunks cache hit ratio is also high. But since this is just synthetic load so actual improvement might not be that good.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]