Fix metadata rendering problem #609
Conversation
Fix various issues with metadata render.
Solved problem that certain schema data is not rendered properly.
meta/SearchConfig.php
Outdated
| */ | ||
| public function __construct($config) | ||
| public function __construct($config, $renderMetadata=false) |
There was a problem hiding this comment.
Minor thing: I would rename the parameter to be independent from it's current usage and align it with what it actually does. Eg. $applyDynamicFilters or something similar
There was a problem hiding this comment.
This still seems to be unsolved. The parameter is has nothing to do with metadata rendering. It defines if dynamic parameters should be applied or not (which coincidentally should not happen when rendering metadata).
There was a problem hiding this comment.
Code of __construct not only blocks dynamic filter, but also blocks limit parameter already defined with aggregation syntax. Is ``$applyDynamicFilters'' still valid in this case?
|
There's also something wrong in the SearchConfig class (see broken tests). Probably a bracket mismatch somewhere? |
Fix wrongly inserted code.
Additional fix for list and cloud metadata issues.
Allow metadata rendering from other pages using "p_get_metadata()", by changing "$ID$" and current pagename resolution method. (e.x.orphanswanted plugin)
|
Any chance you could add test cases? |
|
My apologize, I didn't write unit test before, so It may take some time. |
|
I see there're a lot of refactoring of filter algotithm is going on; It seems I have to overhaul everything in here after refactoring is done? |
Fix various issues with metadata render.
Current code has following problems, with metadata rendering.
This pull request resolves above problems with following solution:
I tested this code with my personal wiki, which has 1,200 pages and a lot of struct aggregation. But if I missed something, please let me know.