Skip to content

[ENH] Add input checks to several functions #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 13, 2022
Merged

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented May 13, 2022

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #36 (9ab68c8) into dev (ba39937) will increase coverage by 38.97%.
The diff coverage is 82.53%.

❗ Current head 9ab68c8 differs from pull request most recent head 0e24e40. Consider uploading reports for the commit 0e24e40 to get more accurate results

@@             Coverage Diff             @@
##              dev      #36       +/-   ##
===========================================
+ Coverage   39.19%   78.17%   +38.97%     
===========================================
  Files          18       20        +2     
  Lines         324      362       +38     
===========================================
+ Hits          127      283      +156     
+ Misses        197       79      -118     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/roi/keepHemisphere.m 94.11% <ø> (ø)
src/utils/removePrefix.m 0.00% <ø> (ø)
src/utils/isBinaryMask.m 60.00% <60.00%> (ø)
src/roi/createRoi.m 92.37% <87.50%> (+92.37%) ⬆️
src/roi/createRoiName.m 89.47% <89.47%> (ø)
src/roi/renameNeuroSynth.m 100.00% <100.00%> (ø)
src/roi/resliceRoiImages.m 94.11% <0.00%> (+94.11%) ⬆️
src/roi/checkRoiOrientation.m 100.00% <0.00%> (+100.00%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Remi-Gau Remi-Gau merged commit 15e21bf into dev May 13, 2022
@Remi-Gau Remi-Gau deleted the add_child_protection branch May 13, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant