-
Notifications
You must be signed in to change notification settings - Fork 684
[6.x] Feature/slideouts #18538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
brianjhanson
wants to merge
19
commits into
6.x
Choose a base branch
from
feature/slideouts
base: 6.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[6.x] Feature/slideouts #18538
Changes from 70 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8a17da7
Fix double action
brianjhanson e9a2f5d
Slideout component + storybook
brianjhanson 92f3304
Merge branch '6.x' of github.com:craftcms/cms into feature/slideouts
brianjhanson 08959aa
Resizable slideouts
brianjhanson 637f2d9
Add focus trap and stories
brianjhanson 605e599
Refactor modals a bit to share Shade component
brianjhanson 09e21b5
Merge branch '6.x' of github.com:craftcms/cms into feature/slideouts
brianjhanson f9c1090
Fix potential crumbs error
brianjhanson 1531e83
Sort template suggestions properly
brianjhanson c1fb68b
Fix potential error
brianjhanson 2d6b5bf
Fix shade in nested slideouts
brianjhanson ace0cd8
Improve mobile slideouts
brianjhanson bd96105
Improve width
brianjhanson c7583d3
Adjust nested slideout story
brianjhanson ad8e352
Merge branch '6.x' of github.com:craftcms/cms into feature/slideouts
brianjhanson 3be7615
Run tests
brianjhanson 5ccb7d0
Hopefully fix tests
brianjhanson 0f212dc
Back to a v-model
brianjhanson 16a0a22
Merge branch '6.x' of github.com:craftcms/cms into feature/slideouts
brianjhanson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import type {StorybookConfig} from '@storybook/vue3-vite'; | ||
| import {mergeConfig} from 'vite'; | ||
| import {resolve} from 'path'; | ||
| import remarkGfm from 'remark-gfm'; | ||
|
|
||
| const config: StorybookConfig = { | ||
| stories: [ | ||
| '../resources/js/components/**/*.mdx', | ||
| '../resources/js/components/**/*.stories.@(js|jsx|mjs|ts|tsx|vue)', | ||
| ], | ||
| addons: [ | ||
| '@storybook/addon-links', | ||
| '@storybook/addon-a11y', | ||
| { | ||
| name: '@storybook/addon-docs', | ||
| options: { | ||
| mdxPluginOptions: { | ||
| mdxCompileOptions: { | ||
| remarkPlugins: [remarkGfm], | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| ], | ||
| framework: { | ||
| name: '@storybook/vue3-vite', | ||
| options: {}, | ||
| }, | ||
| viteFinal(config) { | ||
| return mergeConfig(config, { | ||
| resolve: { | ||
| alias: { | ||
| '@': resolve(__dirname, '../resources/js'), | ||
| '@actions': resolve(__dirname, '../resources/js/actions'), | ||
| }, | ||
| }, | ||
| }); | ||
| }, | ||
| }; | ||
|
|
||
| export default config; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import type {Preview} from '@storybook/vue3'; | ||
|
|
||
| // Import global styles | ||
| import '../resources/css/cp.css'; | ||
|
|
||
| // Import craftcms-cp web components | ||
| import '@craftcms/cp'; | ||
|
|
||
| const preview: Preview = { | ||
| parameters: { | ||
| controls: { | ||
| expanded: true, | ||
| matchers: { | ||
| color: /(background|color)$/i, | ||
| date: /Date$/i, | ||
| }, | ||
| }, | ||
| options: { | ||
| storySort: { | ||
| method: 'alphabetical', | ||
| }, | ||
| }, | ||
| a11y: { | ||
| test: 'todo', | ||
| }, | ||
| }, | ||
| tags: ['autodocs'], | ||
| }; | ||
|
|
||
| export default preview; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.