Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appendHeadHtml()/appendBodyHtml()so existing non-awaited call sites still complete in order.app/resource-jsfallback and endpoint.Reproduce
On any CP page, run:
Before this fix, the second call can log
undefined. With this fix, it should logfunction.To verify the shared queue:
With this fix, it should log
function.Background
The earlier
app/resource-jsfallback was introduced in 1a958a7. It could appear to help because it converted cross-domain CP resource URLs into same-origin requests, keeping jQuery on its same-origin script-loading path. But the append flow still relied on jQuery's script handling, so dependent appended scripts were not guaranteed to execute in order.Relevant jQuery issues: