Skip to content

Conversation

@praveenkumar
Copy link
Member

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohanKanojia
Once this PR has been reviewed and has the lgtm label, please ask for approval from praveenkumar. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cfergeau
Copy link
Contributor

/hold
Just so it's clear, the current consensus is that we don't want to make the change before the next sprint.
It's good to know some of the problems that we'll have in advance

@albfan
Copy link
Contributor

albfan commented Feb 27, 2025

quick test building on go 1.23 arises problems with lint on admin-helper, so crc-org/admin-helper#66 would be related

@openshift-ci
Copy link

openshift-ci bot commented Mar 10, 2025

New changes are detected. LGTM label has been removed.

@praveenkumar
Copy link
Member Author

/retest

@praveenkumar praveenkumar changed the title [WIP] Update golang version to 1.23 Update golang version to 1.23 Mar 10, 2025
@praveenkumar
Copy link
Member Author

@cfergeau should we remove /hold for this because on brew also we have Go1.23.x now?

@cfergeau
Copy link
Contributor

@cfergeau should we remove /hold for this because on brew also we have Go1.23.x now?

Ah sure, we need to proceed with care as there are always side-effects when we raise the go version, but since the release has been done, we can try to move forward.
/unhold

@praveenkumar praveenkumar merged commit 9980d4c into crc-org:main Mar 11, 2025
29 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants