-
Notifications
You must be signed in to change notification settings - Fork 6
feat(CommandPalette): new component #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 82867fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for cube-uikit-docs failed.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 NPM canary releaseDeployed canary version 0.0.0-canary-244457d. |
🏗 Docs are successfully deployed!👀 Preview: https://686d1efbab284cbc0bd8abae--cube-uikit-docs.netlify.app |
🧪 Storybook is successfully deployed!
|
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the ListBox component by introducing a customizable empty-state label, refactoring search filtering to use React Stately’s built-in API, and improving keyboard navigation support. Tests, stories, and documentation are updated to reflect these changes.
- Added
emptyLabel
prop for customizing the “No results found” message - Replaced manual filtering logic with a
collectionFilter
callback for React Stately - Improved keyboard navigation handling and updated associated tests, stories, and docs
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
src/components/fields/ListBox/ListBox.tsx | Implement emptyLabel , refactor filtering, and update keyboard handling |
src/components/fields/ListBox/ListBox.test.tsx | Added tests for keyboard navigation and focus handling |
src/components/fields/ListBox/ListBox.stories.tsx | Added stories for autofocus and custom empty label |
src/components/fields/ListBox/ListBox.docs.mdx | Documented emptyLabel and example usage |
.changeset/shiny-mangos-double.md | Changeset describing new empty-state support |
Co-authored-by: Copilot <[email protected]>
This reverts commit 55ddd13.
No description provided.