Skip to content

Conversation

@MazterQyou
Copy link
Member

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR bumps cube-js/arrow-datafusion@50a3b11, adding support for DISTINCT flag in aggregate UDFs.

@MazterQyou MazterQyou requested review from a team as code owners December 15, 2025 23:32
@github-actions github-actions bot added the rust Pull requests that update Rust code label Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 84.26966% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.98%. Comparing base (5e71919) to head (eef5e2f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 62.50% 6 Missing ⚠️
.../cubesql/src/compile/engine/df/optimizers/utils.rs 0.00% 5 Missing ⚠️
...l/cubesql/src/compile/engine/udf/extension/xirr.rs 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10252      +/-   ##
==========================================
- Coverage   83.25%   77.98%   -5.27%     
==========================================
  Files         247      468     +221     
  Lines       74259    91433   +17174     
  Branches        0     3498    +3498     
==========================================
+ Hits        61825    71308    +9483     
- Misses      12434    19627    +7193     
- Partials        0      498     +498     
Flag Coverage Δ
cube-backend 55.09% <ø> (?)
cubesql 83.25% <84.26%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MazterQyou MazterQyou merged commit 1d93825 into master Dec 16, 2025
123 of 124 checks passed
@MazterQyou MazterQyou deleted the cubesql/udaf-distinct branch December 16, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants