Re enable custom formatters#238
Merged
lonnblad merged 1 commit intocucumber:masterfrom Feb 29, 2020
Merged
Conversation
Contributor
ericmcbride
commented
Feb 29, 2020
- A recent change caused Custom Formatters to not work with concurrency. I dont think that the godog library should not allow the usuage of concurrency on Custom Formatters.
- Custom Formatters not compatible with concurrency #237
- https://github.com/cucumber/godog/pull/204/files#diff-12f3273da1625fbe0b8ae7f4eefe2c3cR280
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
======================================
Coverage 82.5% 82.5%
======================================
Files 16 16
Lines 2663 2663
======================================
Hits 2197 2197
Misses 332 332
Partials 134 134
Continue to review full report at Codecov.
|
lonnblad
approved these changes
Feb 29, 2020
Contributor
|
Hi @ericmcbride, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.