Conversation
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
=======================================
Coverage 84.95% 84.95%
=======================================
Files 19 19
Lines 2619 2619
=======================================
Hits 2225 2225
Misses 271 271
Partials 123 123 Continue to review full report at Codecov.
|
lonnblad
force-pushed
the
updated-readme
branch
2 times, most recently
from
767d6a2 to
ca13865
Compare
mxygem
requested changes
Jun 9, 2020
Member
mxygem
left a comment
mxygem
left a comment
There was a problem hiding this comment.
Nice work! Really the only required change is the one suggestion of on to one
| always bang up-to-date. | ||
| Godog is a community driven Open Source Project within the Cucumber organization, it is maintained by a handfull of developers, but we appreciate contributions from everyone. | ||
|
|
||
| If you are interested in developing Godog, we suggest you to visit on of our slack channels. |
Member
There was a problem hiding this comment.
Suggested change
| If you are interested in developing Godog, we suggest you to visit on of our slack channels. | |
| If you are interested in developing Godog, we suggest you to visit one of our slack channels. |
| - [#committers](https://cucumberbdd.slack.com/archives/C62D0FK0E) - General Cucumber Contributors | ||
|
|
||
| #### Less rework | ||
| ## Install |
Member
There was a problem hiding this comment.
I feel like the install step should be higher up, but lets see how things go here.
|
|
||
| Given we create a new go package **$GOPATH/src/godogs**. From now on, this | ||
| is our work directory `cd $GOPATH/src/godogs`. | ||
| Given we create a new go package **$GOPATH/src/godogs**. From now on, this is our work directory `cd $GOPATH/src/godogs`. |
Member
There was a problem hiding this comment.
Are you sure we want to keep the examples showing being on GOPATH?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.