Fixed an issue when go test is parsing command-line flags#359
Merged
Fixed an issue when go test is parsing command-line flags#359
Conversation
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
==========================================
+ Coverage 79.11% 79.12% +0.01%
==========================================
Files 25 25
Lines 1992 1993 +1
==========================================
+ Hits 1576 1577 +1
Misses 320 320
Partials 96 96
Continue to review full report at Codecov.
|
Member
Author
|
We should try and add a test case that covers this scenario. |
titouanfreville
approved these changes
Nov 25, 2020
Contributor
titouanfreville
left a comment
titouanfreville
left a comment
There was a problem hiding this comment.
I like this solution more than adding a function that will do the trick. Think its clearer like this, less magical :)
lonnblad
force-pushed
the
fix-command-line-flags-issue
branch
from
2a95d1d to
11bd7ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.